pantsbuild / pants / 5604
0%
main: 93%

LAST BUILD BRANCH: multiplatform_pex_with_uv
DEFAULT BRANCH: main
Ran
Jobs 10
Files 335
Run time 7min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
5604

push

travis-ci

John Sirois 
Fix migrate_config to detect explicit [DEFAULT]s.

Previously it was using a public ConfigParser API and a private
ConfigParser data structure - both of which did not include the
'DEFAULT' section by design.

Testing Done:
I reproed the http://github.com/pantsbuild/pants/issues#issue/1758 case
with a local diff of:
```diff
diff --git a/pants.ini b/pants.ini
index 51aa086..5961063 100644
--- a/pants.ini
+++ b/pants.ini
@@ -9,6 +9,11 @@
 #   pants_workdir: the scratch space used to for live builds in this repo

 [DEFAULT]
+read_artifact_caches: ["/mnt/nfs/shared-cache/pants-artifact-cache", "https://foo.example.com/cache/"]
+read_from_artifact_cache: true
+write_artifact_caches: ["/mnt/nfs/shared-cache/pants-artifact-cache", "https://foo.example.com/cache/"]
+write_to_artifact_cache: true
+
```

This led to the following check results with the new code:
```console
Checking config file at ./pants.ini for unmigrated keys.
Found write_to_artifact_cache in section [DEFAULT]. Should be write in section [cache].
Found read_from_artifact_cache in section [DEFAULT]. Should be read in section [cache].
Found read_artifact_caches in section [DEFAULT]. Should be read_from in section [cache].
Found write_artifact_caches in section [DEFAULT]. Should be write_to in section [cache].
Found jvm_options in section [DEFAULT]. Should be options in section [jvm].
```

The 1st 4 messages are what were expected, the last seems unexpected except
that the migration has been partially done, with the legacy option left in
place pending full code migration to jvm subsystem as commented in
pants.ini.

CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/70518341

Bugs closed: 1758, 1798

Reviewed at https://rbcommons.com/s/twitter/r/2465/

14154 of 20019 relevant lines covered (70.7%)

1.33 hits per line

Jobs
ID Job ID Ran Files Coverage
1 5604.1 (CI_FLAGS="-cjlpn 'Various pants self checks'") 0
Travis Job 5604.1
2 5604.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'") 0
66.4
 Travis Job 5604.2
3 5604.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'") 0
66.59
 Travis Job 5604.3
4 5604.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'") 0
Travis Job 5604.4
5 5604.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'") 0
Travis Job 5604.5
6 5604.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'") 0
Travis Job 5604.6
7 5604.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'") 0
Travis Job 5604.7
8 5604.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'") 0
Travis Job 5604.8
9 5604.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'") 0
Travis Job 5604.9
10 5604.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'") 0
Travis Job 5604.10
Source Files on build 5604
Detailed source file information is not available for this build.