5553
0%
main: 93%

Ran 09 Jul 2015 03:47PM UTC

Jobs 10

Files 332

Run time 27min

Badge

Embed ▾

pending completion

Build # 5553

Build Type

push

travis-ci

Committed by Benjy

Commit Message

Some refactoring of global options.

- Makes global option registration be via an Optionable, for uniformity
  with task and subsystem options.
- Move the bootstrap option registration to the same file as the rest
  of the global options registration, for clarity.
- Removed some special-casing of the global scope.
- Removed the buildroot argument to the options bootstrapper. It was only
  used so that reflect.py could substitute a placeholder for display in
  the builddict. We now do this with a simple string replace. I prefer
  this slightly hackier method, isolated to just inside reflect.py, than
  having it leak into the signature of options bootstrapper.
- This change is to support a future change in which registered options will
  know their category (global, subsystem, task), which in turn will
  be used for better help and builddict generation.

Testing Done:
CI passed here: https://travis-ci.org/pantsbuild/pants/builds/70169296

Reviewed at https://rbcommons.com/s/twitter/r/2446/

Coverage Stats

14205 of 19983 relevant lines covered (71.09%)

1.34 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	5553.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	09 Jul 2015 03:47PM UTC		Travis Job 5553.1
2	5553.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'")	09 Jul 2015 03:48PM UTC	66.64	Travis Job 5553.2
3	5553.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")	09 Jul 2015 03:48PM UTC	66.9	Travis Job 5553.3
4	5553.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	09 Jul 2015 03:47PM UTC		Travis Job 5553.4
5	5553.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	09 Jul 2015 03:48PM UTC		Travis Job 5553.5
6	5553.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	09 Jul 2015 03:53PM UTC		Travis Job 5553.6
7	5553.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	09 Jul 2015 03:53PM UTC		Travis Job 5553.7
8	5553.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	09 Jul 2015 03:56PM UTC		Travis Job 5553.8
9	5553.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	09 Jul 2015 03:54PM UTC		Travis Job 5553.9
10	5553.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	09 Jul 2015 04:14PM UTC		Travis Job 5553.10

Source Files on build 5553

Detailed source file information is not available for this build.

pantsbuild / pants / 5553
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5553

pantsbuild / pants / 5553 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5553

pantsbuild / pants / 5553
0%
main: 93%

README BADGES
x