sonata-project / SonataAdminBundle / 12256
79%
3.x: 76%

LAST BUILD BRANCH: test/test/test
DEFAULT BRANCH: 3.x
Ran
Jobs 4
Files 162
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
12256

push

travis-ci

OskarStark 
<a href="https://github.com/sonata-project/SonataAdminBundle/commit/<a class=hub.com/sonata-project/SonataAdminBundle/commit/23289a182d3cb07fd4ba38a8279af78eae7246d8">23289a182<a href="https://github.com/sonata-project/SonataAdminBundle/commit/23289a182d3cb07fd4ba38a8279af78eae7246d8">&quot;&gt;Fix bug with getLoginUrl()

PHPStan complains about `getLoginUrl`

```
------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  Line   src/Security/AdminLoginAuthenticator.php
 ------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  89     Return type (Symfony\Component\HttpFoundation\RedirectResponse) of method App\Security\AdminLoginAuthenticator::getLoginUrl() should be compatible with return type (string) of method Symfony\Component\Security\Guard\Authenticator\AbstractFormLoginAuthenticator::getLoginUrl()
 ------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
```

This method should return a string, this is what abstract method requires

https://github.com/symfony/symfony/blob/</a><a class="double-link" href="https://github.com/sonata-project/SonataAdminBundle/commit/<a class="double-link" href="https://github.com/sonata-project/SonataAdminBundle/commit/c650fe6dfc15c9faf7756514ef5bdc490cb926f4">c650fe6df</a>">c650fe6df</a><a href="https://github.com/sonata-project/SonataAdminBundle/commit/23289a182d3cb07fd4ba38a8279af78eae7246d8">/src/Symfony/Component/Security/Guard/Authenticator/AbstractFormLoginAuthenticator.php#L27-L32

4748 of 5863 relevant lines covered (80.98%)

44.64 hits per line

Jobs
ID Job ID Ran Files Coverage
1 12256.1 (PATH="$HOME/.local/bin:$PATH" SYMFONY_DEPRECATIONS_HELPER=max[self]=0 TARGET=test UPSTREAM_URL=https://github.com/sonata-project/SonataAdminBundle.git PHPUNIT_VERSION=8) 0
80.98
 Travis Job 12256.1
2 12256.2 (PATH="$HOME/.local/bin:$PATH" SYMFONY_DEPRECATIONS_HELPER=max[self]=0 TARGET=test UPSTREAM_URL=https://github.com/sonata-project/SonataAdminBundle.git PHPUNIT_VERSION=8) 0
80.86
 Travis Job 12256.2
3 12256.3 (PATH="$HOME/.local/bin:$PATH" SYMFONY_DEPRECATIONS_HELPER=max[self]=0 TARGET=test UPSTREAM_URL=https://github.com/sonata-project/SonataAdminBundle.git PHPUNIT_VERSION=8 COMPOSER_FLAGS="--prefer-lowest") 0
79.28
 Travis Job 12256.3
4 12256.4 (PATH="$HOME/.local/bin:$PATH" SYMFONY_DEPRECATIONS_HELPER=max[self]=0 TARGET=test UPSTREAM_URL=https://github.com/sonata-project/SonataAdminBundle.git PHPUNIT_VERSION=8 SYMFONY=4.4.*) 0
80.98
 Travis Job 12256.4
Source Files on build 12256
Detailed source file information is not available for this build.