12255
79%
3.x: 76%

Ran 17 Mar 2020 11:32AM UTC

Jobs 4

Files 162

Run time 1min

Badge

Embed ▾

pending completion

Build # 12255

Build Type

push

travis-ci

Committed by

OskarStark

Commit Message

Simplify code, make it more strict

Before:

```php
public function supports(Request $request): bool
{
    if ($request->getPathInfo() != '/admin/login' || $request->getMethod() != 'POST') {
        return false;
    }
    return true;
}
```

After:

```php
public function supports(Request $request): bool
{
    return $request->attributes->get('_route') === 'admin_login' && $request->isMethod('POST');
}
```

Run Details

4748 of 5863 relevant lines covered (80.98%)

44.64 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	12255.1 (PATH="$HOME/.local/bin:$PATH" SYMFONY_DEPRECATIONS_HELPER=max[self]=0 TARGET=test UPSTREAM_URL=https://github.com/sonata-project/SonataAdminBundle.git PHPUNIT_VERSION=8)	17 Mar 2020 11:32AM UTC	80.98	Travis Job 12255.1
2	12255.2 (PATH="$HOME/.local/bin:$PATH" SYMFONY_DEPRECATIONS_HELPER=max[self]=0 TARGET=test UPSTREAM_URL=https://github.com/sonata-project/SonataAdminBundle.git PHPUNIT_VERSION=8)	17 Mar 2020 11:31AM UTC	80.86	Travis Job 12255.2
3	12255.3 (PATH="$HOME/.local/bin:$PATH" SYMFONY_DEPRECATIONS_HELPER=max[self]=0 TARGET=test UPSTREAM_URL=https://github.com/sonata-project/SonataAdminBundle.git PHPUNIT_VERSION=8 COMPOSER_FLAGS="--prefer-lowest")	17 Mar 2020 11:32AM UTC	79.28	Travis Job 12255.3
4	*12255.4 (PATH="$HOME/.local/bin:$PATH" SYMFONY_DEPRECATIONS_HELPER=max[self]=0 TARGET=test UPSTREAM_URL=https://github.com/sonata-project/SonataAdminBundle.git PHPUNIT_VERSION=8 SYMFONY=4.4.)**	17 Mar 2020 11:31AM UTC	80.98	Travis Job 12255.4

Source Files on build 12255

Detailed source file information is not available for this build.

sonata-project / SonataAdminBundle / 12255
79%
3.x: 76%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 12255

sonata-project / SonataAdminBundle / 12255 79% 3.x: 76%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 12255

sonata-project / SonataAdminBundle / 12255
79%
3.x: 76%

README BADGES
x