5490
0%
main: 93%

Ran 29 Jun 2015 11:56PM UTC

Jobs 8

Files 331

Run time 12min

Badge

Embed ▾

pending completion

Build # 5490

Build Type

push

travis-ci

Committed by Nick Howard

Commit Message

When using soft-excludes, ignore all target defined excludes

Currently, soft-excludes only removes excludes from the ivy resolve arguments when some other target has explicitly included that jar. This means that excludes for transitive dependencies of artifacts remain even with soft-excludes enabled. If a target depends on a transitive dependency of an artifact directly, and some other target excludes it, when both are compiled together, the one with the transitive dependency will fail to compile.

This change causes soft-excludes to just skip all target defined excludes, which makes its behavior easier to reason about.

Excludes are now applied separately, so this shouldn't affect how libraries are excluded from classpaths, only how they are communicated to ivy.

Testing Done:
Added unit tests for the new flag on calculate_classpath, CI running off of PR

Bugs closed: 1663

Reviewed at https://rbcommons.com/s/twitter/r/2340/

Coverage Stats

13200 of 19920 relevant lines covered (66.27%)

0.66 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	5490.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	29 Jun 2015 11:56PM UTC		Travis Job 5490.1
2	5490.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'")	29 Jun 2015 11:57PM UTC	66.27	Travis Job 5490.2
4	5490.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	29 Jun 2015 11:58PM UTC		Travis Job 5490.4
5	5490.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	30 Jun 2015 12:00AM UTC		Travis Job 5490.5
6	5490.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	30 Jun 2015 12:04AM UTC		Travis Job 5490.6
8	5490.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	30 Jun 2015 12:06AM UTC		Travis Job 5490.8
9	5490.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	30 Jun 2015 12:09AM UTC		Travis Job 5490.9
10	5490.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	30 Jun 2015 12:09AM UTC		Travis Job 5490.10

Source Files on build 5490

Detailed source file information is not available for this build.

pantsbuild / pants / 5490
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5490

pantsbuild / pants / 5490 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5490

pantsbuild / pants / 5490
0%
main: 93%

README BADGES
x