strongloop / loopback-next / 15857

76%

push

travis-ci-com

feat(repository): remove generic parameters from `Inclusion` type

Ideally, `Inclusion` interface should use type information
from the source model to restrict the allowed values in the filter
for a target model. That is unfortunately rather difficult to achieve,
because an Entity does not provide type information about related models.
We could use {ModelName}WithRelations interface for first-level
inclusion, but that won't handle second-level (and deeper) inclusions.
To keep things simple, `Inclusion` allows any filters and thus does not
require any generic parameter.

BREAKING CHANGE: The type `Inclusion` is no longer generic. Please
update your code and remove any generic arguments provided for the type.

```diff
- Inclusion<MyModel>
+ Inclusion
```

Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>

4335 of 5013 branches covered (86.48%)

Branch coverage included in aggregate %.

11221 of 11794 relevant lines covered (95.14%)

948.32 hits per line