5393
0%
main: 93%

Ran 20 Jun 2015 01:35AM UTC

Jobs 10

Files 332

Run time 15min

Badge

Embed ▾

pending completion

Build # 5393

Build Type

push

travis-ci

Committed by Eric Ayers

Commit Message

In junit-runner, fix an NPE in testFailure() for different scenarios

In AntJunitXmlReportListener, there are cases where `testFailed()` is invoked without a class or invoked without `testStarted()` being called.

Some of these scenarios are outlined in http://junit.org/javadoc/latest/org/junit/runner/notification/RunListener.html

Testing Done:
CI is running at https://travis-ci.org/pantsbuild/pants/builds/67211843

Added a unit test.

Also ran this in our repo. It got rid of the exceptions reported in issue #1234 popping onto the console of the form:

```
                    1) Test mechanism
                     java.lang.NullPointerException
                        at com.twitter.common.junit.runner.ConsoleRunner$StreamCapturingListener.testStarted(ConsoleRunner.java:205)
                        at com.twitter.common.junit.runner.ForwardingListener$3.fire(ForwardingListener.java:60)
                        at com.twitter.common.junit.runner.ForwardingListener.fire(ForwardingListener.java:34)
                        at com.twitter.common.junit.runner.ForwardingListener.testStarted(ForwardingListener.java:58)
                        at com.twitter.common.junit.runner.AbortableListener.testStarted(AbortableListener.java:29)

```

Bugs closed: 1234, 1703

Reviewed at https://rbcommons.com/s/twitter/r/2385/

Coverage Stats

14115 of 19869 relevant lines covered (71.04%)

1.33 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	5393.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	20 Jun 2015 01:36AM UTC		Travis Job 5393.1
2	5393.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'")	20 Jun 2015 01:35AM UTC	67.28	Travis Job 5393.2
3	5393.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")	20 Jun 2015 01:38AM UTC	66.17	Travis Job 5393.3
4	5393.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	20 Jun 2015 01:39AM UTC		Travis Job 5393.4
5	5393.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	20 Jun 2015 01:41AM UTC		Travis Job 5393.5
6	5393.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	20 Jun 2015 01:43AM UTC		Travis Job 5393.6
7	5393.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	20 Jun 2015 01:46AM UTC		Travis Job 5393.7
8	5393.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	20 Jun 2015 01:45AM UTC		Travis Job 5393.8
9	5393.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	20 Jun 2015 01:48AM UTC		Travis Job 5393.9
10	5393.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	20 Jun 2015 01:51AM UTC		Travis Job 5393.10

Source Files on build 5393

Detailed source file information is not available for this build.

pantsbuild / pants / 5393
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5393

pantsbuild / pants / 5393 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5393

pantsbuild / pants / 5393
0%
main: 93%

README BADGES
x