5368
0%
main: 93%

Ran 18 Jun 2015 09:51PM UTC

Jobs 10

Files 332

Run time 10min

Badge

Embed ▾

pending completion

Build # 5368

Build Type

push

travis-ci

Committed by Benjy

Commit Message

Simplify known scopes computation.

Previously we were requiring the goal/task code to compute intermediate
scopes (e.g., to know that if `compile.java` is a scope then so is
`compile`).

However the arg splitter doesn't need this - it only needs to know about
scopes that actually register options.

The parser hierarchy needs to know about those intermediate scopes, but
it can simply compute them as an implementation detail.

So now the goal/task code only computes scopes that you could actually
register options on.

Also removes some superfluous sorting.

Testing Done:
Tests pass locally. CI in flight: https://travis-ci.org/pantsbuild/pants/builds/67415266.

Reviewed at https://rbcommons.com/s/twitter/r/2389/

Coverage Stats

13978 of 19838 relevant lines covered (70.46%)

1.32 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	5368.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	18 Jun 2015 09:51PM UTC		Travis Job 5368.1
2	5368.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'")	18 Jun 2015 09:54PM UTC	66.42	Travis Job 5368.2
3	5368.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")	18 Jun 2015 09:53PM UTC	65.71	Travis Job 5368.3
4	5368.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	18 Jun 2015 09:54PM UTC		Travis Job 5368.4
5	5368.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	18 Jun 2015 09:55PM UTC		Travis Job 5368.5
6	5368.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	18 Jun 2015 09:59PM UTC		Travis Job 5368.6
7	5368.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	18 Jun 2015 10:01PM UTC		Travis Job 5368.7
8	5368.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	18 Jun 2015 10:01PM UTC		Travis Job 5368.8
9	5368.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	18 Jun 2015 10:01PM UTC		Travis Job 5368.9
10	5368.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	18 Jun 2015 10:01PM UTC		Travis Job 5368.10

Source Files on build 5368

Detailed source file information is not available for this build.

pantsbuild / pants / 5368
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5368

pantsbuild / pants / 5368 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5368

pantsbuild / pants / 5368
0%
main: 93%

README BADGES
x