16883
89%

Ran 16 Jan 2020 08:04PM UTC

Jobs 1

Files 271

Run time 24s

Badge

Embed ▾

pending completion

Build # 16883

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

netty: fix a race for channelz at server transport creation

A race condition was reported by user in #6601:

`ServerImpl.start()` calls `NettyServer.start()` while holding `ServerImpl.lock`. `NettyServer.start()` awaits a submitted runnable in eventloop. However, this pending runnable may never be executed because the eventloop might be executing some other task, like `ServerListenerImpl.transportCreated()`, that is trying to acquire `ServerImpl.lock` causing a deadlock.

This PR resolves the particular issue reported in #6601 for server with a single port, but `NettyServer` (https://github.com/grpc/grpc-java/blob/v1.26.0/netty/src/main/java/io/grpc/netty/NettyServer.java#L251) and `ServerImpl` (https://github.com/grpc/grpc-java/blob/v1.26.0/core/src/main/java/io/grpc/internal/ServerImpl.java#L184) in general still have the same potential risk of deadlock, which need further fix.

Run Details

16124 of 18426 relevant lines covered (87.51%)

0.88 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	16883.1	16 Jan 2020 08:04PM UTC	0	87.51	Travis Job 16883.1

Source Files on build 16883

Detailed source file information is not available for this build.

grpc / grpc-java / 16883
89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 16883

grpc / grpc-java / 16883 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 16883

grpc / grpc-java / 16883
89%

README BADGES
x