zopefoundation / Products.CMFCore / 425

86%

push

travis-ci

Fix encoding detection for XML files

In order to detect the correct encoding, XML files are read in binary
format and then the encoding information is extracted by using a
regular expression.

The result could not be used until decoded into a string. This is done
now.

This fixes #85

modified:   CHANGES.rst
modified:   Products/CMFCore/FSPageTemplate.py
new file:   Products/CMFCore/tests/fake_skins/fake_skin/testXMLPT_with_encoding.pt
modified:   Products/CMFCore/tests/test_FSPageTemplate.py

2292 of 3510 branches covered (65.3%)

Branch coverage included in aggregate %.

11 of 11 new or added lines in 2 files covered. (100.0%)

16996 of 19014 relevant lines covered (89.39%)

0.89 hits per line