pantsbuild / pants / 4998
0%
main: 93%

LAST BUILD BRANCH: tdyas/reapi/another-regression-test
DEFAULT BRANCH: main
Ran
Jobs 10
Files 325
Run time 12min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
4998

push

travis-ci

baroquebobcat 
Apply excludes consistently across classpaths

We ran into an issue with isolated compile and excludes.

1. compiling a target that excludes a jar that its dependency requires with the isolated strategy without build cache enabled will cause that dependency to fail to compile, because the ivy resolve excludes the jar entirely.
2. If you use the `resolve.ivy --soft-excludes` option, then the jar will be resolved. But, it will no longer be excluded from the classpath of the target that excludes it. This can cause runtime issues because the excluded jars may end up on the classpath together with the jars that replace them.

What this change does is
- move classpath manipulations into static helper methods
- filter classpaths for excluded jars after they are constructed everywhere they are constructed

The exclude strategy I've ended up at is to collect all the transitive excludes, convert them into partial file paths, and strip jars that match. This has a behavior that's similar to how the global strategy works.

Testing Done:
I ran a test suite that runs into the issues with log4j and log4j-over-slf4j with the changes and saw that tests ran successfully rather than failing to compile or blowing the stack.

I'm also working on a unit test suite and an integration suite.

Bugs closed: 1562

Reviewed at https://rbcommons.com/s/twitter/r/2247/

13531 of 19500 relevant lines covered (69.39%)

1.31 hits per line

Jobs
ID Job ID Ran Files Coverage
1 4998.1 (CI_FLAGS="-cjlpn 'Various pants self checks'") 0
Travis Job 4998.1
2 4998.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'") 0
64.72
 Travis Job 4998.2
3 4998.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'") 0
65.79
 Travis Job 4998.3
4 4998.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'") 0
Travis Job 4998.4
5 4998.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'") 0
Travis Job 4998.5
6 4998.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'") 0
Travis Job 4998.6
7 4998.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'") 0
Travis Job 4998.7
8 4998.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'") 0
Travis Job 4998.8
9 4998.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'") 0
Travis Job 4998.9
10 4998.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'") 0
Travis Job 4998.10
Source Files on build 4998
Detailed source file information is not available for this build.