• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

IJHack / QtPass / 1272
7%
master: 7%

Build:
Build:
LAST BUILD BRANCH: patch-1
DEFAULT BRANCH: master
Ran 02 Oct 2019 08:57PM UTC
Jobs 2
Files 65
Run time 26s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
1272

Pull #482

travis-ci

web-flow
Don't call QtPass::setup() from QtPass class constructor

QtPass::setup() cannot be called from this class constructor as it
possibly calls back MainWindow::config() method.
QtPass constructor is in turn called from the MainWindow one so the
MainWindow object might not be fully constructed yet.

It looks like this was introduced in commit bc19f9eeb5bbcd.

Rename QtPass::setup() to QtPass::init() and call it explicitly at the end
of the MainWindow constructor.

Should fix https://github.com/IJHack/QtPass/issues/466, but the whole thing
really needs a refactoring to establish a clear QtPass -> MainWindow (or
MainWindow -> QtPass) relationship and to make sure there aren't any
circular dependencies there (and other similar bugs).
Pull Request #482: Don't call QtPass::setup() from QtPass class constructor (should fix #466)

8 of 8 new or added lines in 2 files covered. (100.0%)

331 of 4665 relevant lines covered (7.1%)

0.98 hits per line

Jobs
ID Job ID Ran Files Coverage
1 1272.1 02 Oct 2019 08:57PM UTC 0
7.07
Travis Job 1272.1
2 1272.2 02 Oct 2019 08:57PM UTC 0
7.06
Travis Job 1272.2
Source Files on build 1272
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #1272
  • Pull Request #482
  • PR Base - master (#1271)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc