m-lab / ndt-server / 1005

82%

main: 82%

push

travis-ci

ndt7: implement v0.8.0 of the spec (#183)

* ndt7/download/sender: simplify random message generation

As already mentioned in a comment, we don't need to ensure that we
are generating ASCII because the spec does not require that.

Therefore, simplify a little bit the codebase.

* download: implement bulk message size scaling

* ndt7: upgrader: configure large buffers

It does not seem to have big effects for cloud tests, but still
this feels like the correct thing to do.

While there, move the upgrader into handler because otherwise one
that is importing the ndt7 package won't have buffers and, also,
critically, CORS configured.

* fix(handler.go): don't warn and close after failed upgrade

The code in gorilla/websocket already replies for us.

* ndt7: fix usage of read,write deadlines

A deadline is not a timeout. We oughta set the deadline once at the
beginning such that I/O fails as soon as it should.

Also, the functions for setting deadlines in gorilla/websocket
return an error, therefore, check the error.

* ndt7: improve usage of deadlines

Now that we've fixed the place where we set deadlines, let's turn our
attention onto the values of the deadlines.

It does not make any sense to set a long deadline in the closer where
instead we aim to cut it short at this point of the experiment.

For all senders, the correct I/O deadline is 13 seconds rather than
10 seconds, because that gives some leeway for closing the connection
in a clean way when everything is good.

* ndt7/receiver: simplify looping until ctx is done

This is a pattern that @pboothe recommended some time ago.

* model: adapt to changes in ndt7-spec v0.8.0

* fix(cmd/ndt-client): repair build

* Address feedback by @pboothe

50 of 50 new or added lines in 9 files covered. (100.0%)

1493 of 1988 relevant lines covered (75.1%)

0.81 hits per line