1242

DEFAULT BRANCH: master

LAST BUILD BRANCH: patch-1

Repo Added 12 Mar 2017 11:37AM UTC

Total Files 65

# Builds 507 Last

Badge

Embed ▾

Committed 8 Sep 2019 - 15:58 coverage decreased (-0.02%) to 6.95%

Build # 1242

Build Type

Pull #473

travis-ci

Committed by

web-flow

Commit Message

Add missing finishedShow() signal connection in PasswordDialog constructor

Commit 990b89c0ee6231 ("Removed unused headers from mainwindow.cpp. Disable UseTrayIcon if it's not available for the OS.")
moved Pass finishedShow() signal connection for a PasswordDialog from
MainWindow::setPassword() to the (first) PasswordDialog constructor.

However PasswordDialog has actually two constructors, and the second one
needs to make this connection, too, otherwise the "Edit password" function
does not load the edited entry data.

See:
https://github.com/IJHack/QtPass/issues/423
https://github.com/IJHack/QtPass/issues/465
https://github.com/IJHack/QtPass/issues/470

Pull Request Pull Request #473: Add missing finishedShow() signal connection in PasswordDialog constructor (fixes the "Edit password" function)

Run Details

0 of 2 new or added lines in 1 file covered. (0.0%)

327 of 4705 relevant lines covered (6.95%)

0.89 hits per line

New Missed Lines in Diff

Lines	Coverage	∆	File
2	56.9	-1.0%	src/passworddialog.cpp

Jobs

Coverage	Job	Files Covered	Ran
6.97	1242.1	65	08 Sep 2019 04:01PM UTC	Travis Job 1242.1
6.95	1242.2	65	08 Sep 2019 04:01PM UTC	Travis Job 1242.2

IJHack / QtPass / 1242

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Jobs

Source Files on build 1242

IJHack / QtPass / 1242

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Jobs

Source Files on build 1242

README BADGES
x