4839
0%
main: 93%

Ran 12 May 2015 12:50AM UTC

Jobs 10

Files 326

Run time 14min

Badge

Embed ▾

pending completion

Build # 4839

Build Type

push

travis-ci

Committed by Benjy

Commit Message

Move a comment to work around a pytest bug.

When that test fails, pytest attempts to construct a verbose backtrace.
However that comment in the middle of a multiline list literal tickles
a bug in the backtrace construction code that causes pytest to fail hard
with an INTERNALERROR, instead of showing the details of the underlying bug.

While debugging this, I noticed that we don't constrain the versions of
pytest that we bake into the test chroot, so it will end up being a
different version than the one in 3rdparty/python/requirements.txt.
This is pretty confusing, so I added the relevant constraints.

See here for an example of this useless INTERNALERROR dump:
https://travis-ci.org/pantsbuild/pants/jobs/62120623

Testing Done:
Relevant test passes locally in otherwise unmodified repo.
Relevant test fails with INTERNALERROR when test is deliberately broken before this change.
Relevant test fails with useful backtrace when deliberately broken after this change.

CI pending: https://travis-ci.org/pantsbuild/pants/builds/62150849

Bugs closed: 1525

Reviewed at https://rbcommons.com/s/twitter/r/2201/

Coverage Stats

13398 of 19364 relevant lines covered (69.19%)

0.69 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	4839.1 (CI_FLAGS="-cjlpnet 'Various pants self checks'")	12 May 2015 12:50AM UTC		Travis Job 4839.1
2	4839.2 (CI_FLAGS="-fkmsrcjlpn 'Test examples and testprojects'")	12 May 2015 12:50AM UTC		Travis Job 4839.2
3	4839.3 (CI_FLAGS="-fkmsrcnet 'Unit tests for pants and pants-plugins'")	12 May 2015 12:54AM UTC	69.19	Travis Job 4839.3
4	4839.4 (CI_FLAGS="-fkmsrcjlpet 'Python contrib tests'")	12 May 2015 12:51AM UTC		Travis Job 4839.4
5	4839.5 (CI_FLAGS="-fkmsrjlpnet -i 6:0 'Python integration tests for pants - shard 1'")	12 May 2015 12:52AM UTC		Travis Job 4839.5
6	4839.6 (CI_FLAGS="-fkmsrjlpnet -i 6:1 'Python integration tests for pants - shard 2'")	12 May 2015 01:00AM UTC		Travis Job 4839.6
7	4839.7 (CI_FLAGS="-fkmsrjlpnet -i 6:2 'Python integration tests for pants - shard 3'")	12 May 2015 01:03AM UTC		Travis Job 4839.7
8	4839.8 (CI_FLAGS="-fkmsrjlpnet -i 6:3 'Python integration tests for pants - shard 4'")	12 May 2015 01:04AM UTC		Travis Job 4839.8
9	4839.9 (CI_FLAGS="-fkmsrjlpnet -i 6:4 'Python integration tests for pants - shard 5'")	12 May 2015 01:02AM UTC		Travis Job 4839.9
10	4839.10 (CI_FLAGS="-fkmsrjlpnet -i 6:5 'Python integration tests for pants - shard 6'")	12 May 2015 01:02AM UTC		Travis Job 4839.10

Source Files on build 4839

Detailed source file information is not available for this build.

pantsbuild / pants / 4839
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4839

pantsbuild / pants / 4839 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4839

pantsbuild / pants / 4839
0%
main: 93%

README BADGES
x