4820
0%
main: 93%

Ran 10 May 2015 10:47PM UTC

Jobs 10

Files 325

Run time 12min

Badge

Embed ▾

pending completion

Build # 4820

Build Type

push

travis-ci

Committed by

jsirois

Commit Message

Eliminate the globs.__sub__ use in option package.

This leaves a target alias in-place for those used to it but moves the
migration tool to the migrations tree.

Testing Done:
https://rbcommons.com/s/twitter/r/2082/ deprecated +/-, but missed cleaning up pants itself:
```console
$ PANTS_DEV=1 ./pants list src/python/pants/option/:
*** Running pants in dev mode from /home/jsirois/dev/3rdparty/pants/src/python/pants/bin/pants_exe.py ***
WARN] <string>:6: DeprecationWarning:
pants.backend.core.wrapped_globs.__sub__ is deprecated and will be removed in version 0.0.35:
Instead of glob arithmetic, use glob(..., exclude=[...])

INFO] Detected git repository at /home/jsirois/dev/3rdparty/pants on branch master
src/python/pants/option:migrate_config
src/python/pants/option:option
```

After the fix deprecation is gone and the options migration tool still works:
```console
$ rm -r dist/ && PANTS_DEV=1 ./pants binary src/python/pants/option:migrate_config
$ ./dist/migrate_config.pex
Checking config file at ./pants.ini for unmigrated keys.
```

CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/62009350

Bugs closed: 1520

Reviewed at https://rbcommons.com/s/twitter/r/2197/

Coverage Stats

13367 of 19330 relevant lines covered (69.15%)

0.69 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	4820.1 (CI_FLAGS="-cjlpnet 'Various pants self checks'")	10 May 2015 10:49PM UTC		Travis Job 4820.1
2	4820.2 (CI_FLAGS="-fkmsrcjlpn 'Test examples and testprojects'")	10 May 2015 10:49PM UTC		Travis Job 4820.2
3	4820.3 (CI_FLAGS="-fkmsrcnet 'Unit tests for pants and pants-plugins'")	10 May 2015 10:53PM UTC	69.15	Travis Job 4820.3
4	4820.4 (CI_FLAGS="-fkmsrcjlpet 'Python contrib tests'")	10 May 2015 10:47PM UTC		Travis Job 4820.4
5	4820.5 (CI_FLAGS="-fkmsrjlpnet -i 6:0 'Python integration tests for pants - shard 1'")	10 May 2015 10:48PM UTC		Travis Job 4820.5
6	4820.6 (CI_FLAGS="-fkmsrjlpnet -i 6:1 'Python integration tests for pants - shard 2'")	10 May 2015 10:54PM UTC		Travis Job 4820.6
7	4820.7 (CI_FLAGS="-fkmsrjlpnet -i 6:2 'Python integration tests for pants - shard 3'")	10 May 2015 10:57PM UTC		Travis Job 4820.7
8	4820.8 (CI_FLAGS="-fkmsrjlpnet -i 6:3 'Python integration tests for pants - shard 4'")	10 May 2015 11:00PM UTC		Travis Job 4820.8
9	4820.9 (CI_FLAGS="-fkmsrjlpnet -i 6:4 'Python integration tests for pants - shard 5'")	10 May 2015 10:58PM UTC		Travis Job 4820.9
10	4820.10 (CI_FLAGS="-fkmsrjlpnet -i 6:5 'Python integration tests for pants - shard 6'")	10 May 2015 10:59PM UTC		Travis Job 4820.10

Source Files on build 4820

Detailed source file information is not available for this build.

pantsbuild / pants / 4820
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4820

pantsbuild / pants / 4820 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4820

pantsbuild / pants / 4820
0%
main: 93%

README BADGES
x