3389
96%
master: 97%

Ran 19 Aug 2019 10:58PM UTC

Jobs 5

Files 97

Run time 3min

Badge

Embed ▾

pending completion

Build # 3389

Build Type

push

travis-ci

Committed by

brandur-stripe

Commit Message

Minor cleanup in `StripeClient` (#832)

I ended up having to relax the maximum method line length in a few
previous PRs, so I wanted to try one more cleanup pass in
`execute_request` to see if I could get it back at all.

The answer was "not by much" (without reducing clarity), but I found a
few places that could be tweaked. Unfortunately, ~50 lines is probably
the "right" length for this method in that you _could_ extract it
further, but you'd end up passing huge amounts of state all over the
place in method parameters, and it really wouldn't look that good.

Run Details

1839 of 1915 relevant lines covered (96.03%)

2448.42 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	3389.1 (2.3)	19 Aug 2019 10:58PM UTC	96.14	Travis Job 3389.1
2	3389.2 (2.4)	19 Aug 2019 10:58PM UTC	96.14	Travis Job 3389.2
3	3389.3 (2.5)	19 Aug 2019 10:58PM UTC	96.14	Travis Job 3389.3
4	3389.4 (2.6)	19 Aug 2019 10:58PM UTC	96.11	Travis Job 3389.4
5	3389.5 (jruby-9.2.7.0)	19 Aug 2019 11:01PM UTC	0.0	Travis Job 3389.5

Source Files on build 3389

Detailed source file information is not available for this build.

stripe / stripe-ruby / 3389
96%
master: 97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3389

stripe / stripe-ruby / 3389 96% master: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3389

stripe / stripe-ruby / 3389
96%
master: 97%

README BADGES
x