stripe / stripe-ruby / 3380
96%
master: 97%

LAST BUILD BRANCH: HEAD
DEFAULT BRANCH: master
Ran
Jobs 5
Files 97
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
3380

push

travis-ci

brandur-stripe 
Reset connections when connection-changing configuration changes (#829)

Adds a few basic features around connection and connection manager
management:

* `clear` on connection manager, which calls `finish` on each active
  connection and then disposes of it.

* A centralized cross-thread tracking system for connection managers in
  `StripeClient` and `clear_all_connection_managers` which clears all
  known connection managers across all threads in a thread-safe way.

The addition of these allow us to modify the implementation of some of
our configuration on `Stripe` so that it can reset all currently open
connections when its value changes.

This fixes a currently problem with the library whereby certain
configuration must be set before the first request or it remains fixed
on any open connections. For example, if `Stripe.proxy` is set after a
request is made from the library, it has no effect because the proxy
must have been set when the connection was originally being initialized.

The impetus for getting this out is that I noticed that we will need
this internally in a few places when we're upgrading to stripe-ruby V5.
Those spots used to be able to hack around the unavailability of this
feature by just accessing the Faraday connection directly and resetting
state on it, but in V5 `StripeClient#conn` is gone, and that's no longer
possible.

1838 of 1914 relevant lines covered (96.03%)

2450.87 hits per line

Jobs
ID Job ID Ran Files Coverage
1 3380.1 (2.3) 97
96.13
 Travis Job 3380.1
2 3380.2 (2.4) 97
96.13
 Travis Job 3380.2
3 3380.3 (2.5) 97
96.14
 Travis Job 3380.3
4 3380.4 (2.6) 97
96.11
 Travis Job 3380.4
5 3380.5 (jruby-9.2.7.0) 97
0.0
 Travis Job 3380.5
Source Files on build 3380