activeadmin / activeadmin / 4228

16%

master: 79%

Build Type

push

travis-ci

Committed by Sean Linsley

Commit Message

use `columns_hash` to get around deprecation warning

we couldn’t use `type_for_column` since:
- it’s not intended as a public method and
- it would return a null object if the column had the default value (nil)

for example:
```
expected: "No"
     got: ""

(compared using ==)
 (RSpec::Expectations::ExpectationNotMetError)
./features/step_definitions/table_steps.rb:96:in `assert_cells_match'
./features/step_definitions/table_steps.rb:79:in `block (2 levels) in assert_tables_match'
./features/step_definitions/table_steps.rb:75:in `each_index'
./features/step_definitions/table_steps.rb:75:in `block in assert_tables_match'
./features/step_definitions/table_steps.rb:74:in `each_index'
./features/step_definitions/table_steps.rb:74:in `assert_tables_match'
./features/step_definitions/table_steps.rb:115:in `/^I should see the "([^"]*)" table:$/'
features/index/index_as_table.feature:252:in `Then I should see the "index_table_posts" table:'

Failing Scenarios:
cucumber features/index/index_as_table.feature:244 # Scenario: Sorting
```

Run Details

2 of 2 new or added lines in 1 file covered. (100.0%)

3598 of 3839 relevant lines covered (93.72%)

616.06 hits per line