grpc / grpc-java / 14673

89%

push

travis-ci

context:  fix race between CancellableContext and Context

The `pendingDeadline` variable is modified from the ctor of CancellableContext, but it isn't final.  The cancellation can happen before the variable is assigned.  It's generally bad practice to leak the this reference from the ctor to other threads anyways.

This code refactors the deadline calculation and scheduling so that `pendingDeadline` is modified under the lock, and the `this` reference is not exposed.

Discovered by TSAN.

22 of 22 new or added lines in 1 file covered. (100.0%)

15143 of 17351 relevant lines covered (87.27%)

0.87 hits per line