Instagram
/
IGListKit
/
2335
100%
|
Ran
|
Jobs
2
|
Files
105
|
Run time
10min
|
Badge
Embed ▾
README BADGES
|
push
travis-ci
facebook-github-bot<a href="https://github.com/Instagram/IGListKit/commit/0ac855df9">Fix - Cell Reordering in IGListBindingSectionController (viewModels array not being updated) (#1274) Summary: - See #1262 (cell reordering using a binding section controller caused problems) ## Changes in this pull request - Added method override in `IGListBindingSectionController` to update the internal `viewModels` array after a cell has been moved - Subclasses of IGListBindingSectionController require to call super Issue fixed: #1262 I've added a test for this change. Is this enough? Or should I add more corner cases or something? ### Checklist Some tests fail, but they do seem unrelated. I don't know if this is normal. I haven't changed anything regarding those failing tests. - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1274 Reviewed By: candance Differential Revision: D15592822 Pulled By: lorixx fbshipit-source-id: </a><a class="double-link" href="https://github.com/Instagram/IGListKit/commit/d81c18bec">d81c18bec</a>
13466 of 14542 relevant lines covered (92.6%)
447.6 hits per line
Jobs
Source Files on build 2335
Detailed source file information is not available for this build.