Instagram
/
IGListKit
/
2330
100%
|
Ran
|
Jobs
2
|
Files
105
|
Run time
10min
|
Badge
Embed ▾
README BADGES
|
push
travis-ci
facebook-github-bot<a href="https://github.com/Instagram/IGListKit/commit/08bf69cc2">Fix #1275 layouts inconsistency in `updateAnimated:completion` of IGListBindingSectionController (#1285) Summary: ## Changes in this pull request Issue fixed: https://github.com/Instagram/IGListKit/issues/1275 This PR is straintforward solution as mentioned in https://github.com/Instagram/IGListKit/issues/1275. When I finished it, I realized that it is not a problem in `IGListCollectionViewLayout Partial Optimization` and `IGListBindingSectionController` deserved it. Maybe `IGListCollectionViewLayout` is rarely used because of great builtin UICollectionViewFlowLayout or cells in section rarely need changing their sizes in practices. Despite it is not `IGListCollectionViewLayout`'s fault, I think it can be more optimized against `invalidateLayoutWithContext`. I would like to make an another PR to optimize it. Due to this PR just giving a proposed solution, it lacks of adding tests and changing log. When this solution is accepted, I would like to complete these todos. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1285 Reviewed By: candance Differential Revision: D15592807 Pulled By: lorixx fbshipit-source-id: </a><a class="double-link" href="https://github.com/Instagram/IGListKit/commit/ae06abce8">ae06abce8</a>
13437 of 14513 relevant lines covered (92.59%)
448.12 hits per line
Jobs
Source Files on build 2330
Detailed source file information is not available for this build.