pantsbuild / pants / 4503
0%
main: 93%

LAST BUILD BRANCH: fix-bsp-scalac-plugin-paths
DEFAULT BRANCH: main
Ran
Jobs 10
Files 322
Run time 18min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
4503

push

travis-ci

Benjy 
Convert two existing concepts (RunTracker and the jar tool) to be subsystems.

- The RunTracker change is straightforward.

- There is now a JarTool subsystem.  But implementing this neatly
  required some changes to the JVM tool machinery:

  + The old JvmToolTaskMixin is now JvmToolMixin. I.e., you don't have
    to be a task to use JVM tools. Indeed, subsystems can mix this in
    in order to register and bootstrap JVM tools.

  + JvmToolTaskMixin is now a thin subclass of JvmToolMixin, adapting
    it for ease of use by tasks. In the future we might make all
    JVM tools (compilers etc.) into subsystems and then not need
    JvmToolTaskMixin at all.

  + The new JarTool subsystem does two things:
      1) Bootstraps the jar tool and handles its options.
      2) Actually runs the jar tool with given args in a given runner.
         This interface is slightly awkward perhaps, but very reusable.
         And we already pass runners around as arguments elsewhere anyway.

- Removed some clunky code in JvmToolTaskTestBase that registers options
  for BootstrapJvmTools, which is not the task under test but is needed
  to bootstrap tools for the task under test.  Instead overrides context() to
  add BootstrapJvmTools to the list of tasks the base class already clunkily
  registers options for (in addition to the task under test)...

- TODO: JarTool is now tested indirectly in test_jar_task.py,
  but we might want to also test the now-standalone subsystem directly.

Testing Done:
CI passes: https://travis-ci.org/pantsbuild/pants/builds/58631095

Reviewed at https://rbcommons.com/s/twitter/r/2081/

12967 of 18759 relevant lines covered (69.12%)

0.69 hits per line

Jobs
ID Job ID Ran Files Coverage
1 4503.1 (CI_FLAGS="-cjlpnet 'Various pants self checks'") 0
Travis Job 4503.1
2 4503.2 (CI_FLAGS="-fkmsrcjlpn 'Test examples and testprojects'") 0
Travis Job 4503.2
3 4503.3 (CI_FLAGS="-fkmsrcnet 'Unit tests for pants and pants-plugins'") 0
69.12
 Travis Job 4503.3
4 4503.4 (CI_FLAGS="-fkmsrcjlpet 'Python contrib tests'") 0
Travis Job 4503.4
5 4503.5 (CI_FLAGS="-fkmsrjlpnet -i 6:0 'Python integration tests for pants - shard 1'") 0
Travis Job 4503.5
6 4503.6 (CI_FLAGS="-fkmsrjlpnet -i 6:1 'Python integration tests for pants - shard 2'") 0
Travis Job 4503.6
7 4503.7 (CI_FLAGS="-fkmsrjlpnet -i 6:2 'Python integration tests for pants - shard 3'") 0
Travis Job 4503.7
8 4503.8 (CI_FLAGS="-fkmsrjlpnet -i 6:3 'Python integration tests for pants - shard 4'") 0
Travis Job 4503.8
9 4503.9 (CI_FLAGS="-fkmsrjlpnet -i 6:4 'Python integration tests for pants - shard 5'") 0
Travis Job 4503.9
10 4503.10 (CI_FLAGS="-fkmsrjlpnet -i 6:5 'Python integration tests for pants - shard 6'") 0
Travis Job 4503.10
Source Files on build 4503
Detailed source file information is not available for this build.