Instagram
/
IGListKit
/
2322
100%
|
Ran
|
Jobs
2
|
Files
101
|
Run time
8min
|
Badge
Embed ▾
README BADGES
|
push
travis-ci
facebook-github-bot<a href="https://github.com/Instagram/IGListKit/commit/619b83571">Fix scrollToObject: inconsistency bug when scrolling to bottom/right with content inset (#1284) Summary: The implementation of ```Objective-C -[IGListAdapter scrollToObject:supplementaryKinds:scrollDirection:scrollPosition:animated:] ``` has little inconsistencies where the `UICollectionViewScrollPositionLeft` and `UICollectionViewScrollPositionTop` considering the content inset left/top of the collection view was being applied to the final offset. However, the `UICollectionViewScrollPositionRight` and `UICollectionViewScrollPositionBottom` ignoring the content inset right/bottom of the collection view was being applied to the final offset. The different result is that scrolling to the most `Left/Top`, the first section content always be visible by considering its content inset while scrolling to the most `Right/Bottom`, the last section content always be fully displayed but not be fully visible by considering its content inset. ## Changes in this pull request Issue fixed: # ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1284 Reviewed By: lorixx Differential Revision: D13590416 Pulled By: lorixx fbshipit-source-id: </a><a class="double-link" href="https://github.com/Instagram/IGListKit/commit/ae52be9e5">ae52be9e5</a>
13310 of 14379 relevant lines covered (92.57%)
451.25 hits per line
Jobs
Source Files on build 2322
Detailed source file information is not available for this build.