optimizely / javascript-sdk / 815

78%

push

travis-ci

fix (datafile management): Clear timeout created in onReady method when it's no longer needed (#272)

Summary:

onReady sets a timeout that fulfills a timeout promise. The timeout promise is only used to race against the ready promise provided by ProjectConfigManager. So, as soon as ProjectConfigManager's ready promise is fulfilled, the timeout can be cleared. Before this change, the timeout would only be cleared in the close method.

Test plan:

Manual & added unit test

584 of 635 branches covered (91.97%)

Branch coverage included in aggregate %.

5726 of 5831 relevant lines covered (98.2%)

92.65 hits per line