pantsbuild / pants / 4475
0%
main: 93%

LAST BUILD BRANCH: go-modcache-named-cache
DEFAULT BRANCH: main
Ran
Jobs 10
Files 319
Run time 29min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
4475

push

travis-ci

jsirois 
Initial port of twitter/commons jar-tool.

Copy jar-tool in from twitter/commons.

This ports the jar-tool used by pants but does not actually
configure pants to use the ported tool.  That will come later after
the tool is published: https://github.com/pantsbuild/pants/issues/1361

The jar-tool in twitter/commons will be deleted after this tool is
published and consumed by pants HEAD.

Testing Done:
Locally dogfooded the jar-tool to build itself comparing before/after:
```console
$ PANTS_DEV=1 ./pants clean-all binary
src/java/org/pantsbuild/tools/jar:main
$ cp dist/jar-tool.jar dist/jar-tool.created-by.c.t.c.jar

$ git diff
diff --git a/BUILD.tools b/BUILD.tools
index 81fc8d8..b233485 100644
--- a/BUILD.tools
+++ b/BUILD.tools
@@ -152,7 +152,8 @@ jar_library(name = 'spindle-codegen',

 jar_library(name = 'jar-tool',
             jars = [
-              jar(org = 'com.twitter.common', name = 'jar-tool', rev =
               '0.1.9')
+              jar(org = 'com.twitter.common', name = 'jar-tool', rev =
'none', mutable=True,
+
url='file:///home/jsirois/dev/3rdparty/jsirois-pants4/dist/jar-tool.jar')
             ])

 jar_library(name = 'jarjar',
diff --git a/src/python/pants/backend/jvm/tasks/jar_task.py
b/src/python/pants/backend/jvm/tasks/jar_task.py
index 438e1e5..7298fac 100644
--- a/src/python/pants/backend/jvm/tasks/jar_task.py
+++ b/src/python/pants/backend/jvm/tasks/jar_task.py
@@ -288,7 +288,7 @@ class JarTask(NailgunTask):
         # need the same JVM args as its parent.
         jvm_options = self.context.config.getlist('jar-tool',
'jvm_args', default=['-Xmx64M'])
         self.runjava(self.tool_classpath('jar-tool'),
-                     'com.twitter.common.jar.tool.Main',
+                     'org.pantsbuild.tools.jar.Main',
                      jvm_options=jvm_options,
                      args=args,
                      workunit_name='jar-tool',$
$ PANTS_DEV=1 ./pants clean-all binary
src/java/org/pantsbuild/tools/jar:main

$ mkdir /tmp/jar-tool.jar /tmp/jar-tool.created-by.c.t.c.jar
$ unzip -qd /tmp/jar-tool.created-by.c.t.c.jar
dist/jar-tool.created-by.c.t.c.jar
$ unzip -qd /tmp/jar-tool.jar dist/jar-tool.jar
$ diff -r /tmp/jar-tool.created-by.c.t.c.jar /tmp/jar-tool.jar
diff -r /tmp/jar-tool.created-by.c.t.c.jar/META-INF/MANIFEST.MF
/tmp/jar-tool.jar/META-INF/MANIFEST.MF
2c2
< Created-By: com.twitter.common.jar.tool.JarBuilder
---
> Created-By: org.pantsbuild.tools.jar.JarBuilder
```

CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/58311252

Bugs closed: 1362, 1415

Reviewed at https://rbcommons.com/s/twitter/r/2071/

12885 of 18658 relevant lines covered (69.06%)

0.69 hits per line

Jobs
ID Job ID Ran Files Coverage
1 4475.1 (CI_FLAGS="-cjlpnet 'Various pants self checks'") 0
Travis Job 4475.1
2 4475.2 (CI_FLAGS="-fkmsrcjlpn 'Test examples and testprojects'") 0
Travis Job 4475.2
3 4475.3 (CI_FLAGS="-fkmsrcnet 'Unit tests for pants and pants-plugins'") 0
69.06
 Travis Job 4475.3
4 4475.4 (CI_FLAGS="-fkmsrcjlpet 'Python contrib tests'") 0
Travis Job 4475.4
5 4475.5 (CI_FLAGS="-fkmsrjlpnet -i 6:0 'Python integration tests for pants - shard 1'") 0
Travis Job 4475.5
6 4475.6 (CI_FLAGS="-fkmsrjlpnet -i 6:1 'Python integration tests for pants - shard 2'") 0
Travis Job 4475.6
7 4475.7 (CI_FLAGS="-fkmsrjlpnet -i 6:2 'Python integration tests for pants - shard 3'") 0
Travis Job 4475.7
8 4475.8 (CI_FLAGS="-fkmsrjlpnet -i 6:3 'Python integration tests for pants - shard 4'") 0
Travis Job 4475.8
9 4475.9 (CI_FLAGS="-fkmsrjlpnet -i 6:4 'Python integration tests for pants - shard 5'") 0
Travis Job 4475.9
10 4475.10 (CI_FLAGS="-fkmsrjlpnet -i 6:5 'Python integration tests for pants - shard 6'") 0
Travis Job 4475.10
Source Files on build 4475
Detailed source file information is not available for this build.