pantsbuild / pants / 4468

0%

main: 93%

push

travis-ci

Fix BootstrapJvmTools to plumb jvm options to Shader.

This was the root cause of Shader getting killed in TravisCI containers.
In those containers, 4g of memory is available but the jvm detects the
full host ram and so defaults to 16g as the default XmX. With no
jvm_options being plumbed to the Shader (they were already to the
underlying IvyUtils and JarTask) - it happily bombed past the container
memory and was OOMkilled.

Testing Done:
I double-checked in the `./pants server` and the `Shader` spawn was the
only one of 5 jvm tasks (3 resolves, 1 fat-jar creation, 1 shade) to not
have `-Xmx`.

I rigged a special ci run and found the default `MaxHeapSize` was above the
container limit:
```console
$ uname -a
java -XX:+PrintFlagsFinal -version | grep HeapSize
./build-support/bin/ci.sh -x ${CI_FLAGS}
Linux testing-worker-linux-docker-29022e06-3351-linux-15 3.13.0-40-generic #69-Ubuntu SMP Thu Nov 13 17:53:56 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
    uintx ErgoHeapSizeLimit                         = 0               {product}
    uintx HeapSizePerGCThread                       = 87241520        {product}
    uintx InitialHeapSize                          := 989377216       {product}
    uintx LargePageHeapSizeThreshold                = 134217728       {product}
    uintx MaxHeapSize                              := 15831400448     {product}
java version "1.7.0_76"
Java(TM) SE Runtime Environment (build 1.7.0_76-b13)
Java HotSpot(TM) 64-Bit Server VM (build 24.76-b04, mixed mode)
[== 00:00 CI BEGINS: 'Unit tests for pants and pants-plugins' ==]
...
```

CI away here:
  https://travis-ci.org/pantsbuild/pants/builds/58283618

Bugs closed: 1417

Reviewed at https://rbcommons.com/s/twitter/r/2073/

3 of 3 new or added lines in 2 files covered. (100.0%)

12885 of 18658 relevant lines covered (69.06%)

0.69 hits per line