pantsbuild / pants / 4407

0%

main: 93%

push

travis-ci

Add 'java-resource' and 'java-test-resource' content type for Resources Roots.

I also discovered an error in how resources content types were added. The target.target_base was used as root_dir to add resources instead of resource.target_base.
This was masked by the fact resource target was also included in self.context_targets. The right source root was registered then.

In this review, after fixing above bug, i saw 2 content roots registered for the same resource target. Changed the self.sources to be a set instead of an array.

Testing Done:
https://travis-ci.org/pantsbuild/pants/builds/57812381

Reviewed at https://rbcommons.com/s/twitter/r/2046/

18 of 18 new or added lines in 1 file covered. (100.0%)

12683 of 18414 relevant lines covered (68.88%)

0.69 hits per line