4135
79%

Ran 09 Apr 2015 03:47AM UTC

Jobs 3

Files 144

Run time 5min

Badge

Embed ▾

pending completion

Build # 4135

Build Type

Pull #3848

travis-ci

Committed by Gabe Durazo

Commit Message

Fix pagination_total index option to prevent SELECT count(*) queries

The pagination_total option is supposed to prevent expensive SELECT
count(*) queries from being performed when viewing a resource's index
page.

However, while this option was hiding the display of the total number of
pages, it did not actually prevent the query from being performed.

There were two reasons:

In `#build_pagination`, the line:

`text_node paginate collection, options`

would trigger Kaminari to call `#total_pages` on the collection, which would
trigger the query:

```
    def paginate(scope, options = {}, &block)
      options[:total_pages] ||= options[:num_pages] || scope.total_pages
```

By passing in the `:total_pages` option, we short circuit this assignment
and avoid the query.

That fix was not sufficient. In `#page_entries_info`, the call
`collection.num_pages` also triggered a SELECT count(*). I re-arranged
the conditionals to avoid that call if `@display_total` is false, while
trying to keep the behavior the same.

Pull Request Pull Request #3848:

Run Details

3625 of 3865 relevant lines covered (93.79%)

304.29 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
4	4135.4 (2.1, RAILS=3.2.21)	09 Apr 2015 03:49AM UTC	144	93.53	Travis Job 4135.4
5	4135.5 (2.2, RAILS=4.1.8)	09 Apr 2015 03:47AM UTC	144	93.76	Travis Job 4135.5
6	4135.6 (2.2, RAILS=4.2.0)	09 Apr 2015 03:52AM UTC	144	93.76	Travis Job 4135.6

Source Files on build 4135

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

activeadmin / activeadmin / 4135
79%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4135

activeadmin / activeadmin / 4135 79%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4135

activeadmin / activeadmin / 4135
79%

README BADGES
x