pantsbuild / pants / 4387
0%
main: 93%

LAST BUILD BRANCH: pantsd/stdio-per-run-log
DEFAULT BRANCH: main
Ran
Jobs 10
Files 319
Run time 156min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
4387

push

travis-ci

jsirois 
Copy junit-runner in from twitter/commons.

This ports the junit-runner used by pants but does not actually
configure pants to use the ported runner.  That will come later after
the tool is published: https://github.com/pantsbuild/pants/issues/1361

The junit-runner in twitter/commons will be deleted after this tool is
published and consumed by pants HEAD.

Testing Done:
I dogfooded the runner to test itself via:
```console
$ pants.dev clean-all test {src,tests}/java/::
```
And by using the instructions in
`tests/java/org/pantsbuild/tools/junit/README` with the following diff:
```diff
$ git diff
diff --git a/BUILD.tools b/BUILD.tools
index fc53e75..da0a936 100644
--- a/BUILD.tools
+++ b/BUILD.tools
@@ -123,7 +123,8 @@ jar_library(name = 'junit',
             jars = [
               jar(org = 'junit', name = 'junit-dep', rev = '4.10'),
               jar(org = 'org.hamcrest', name = 'hamcrest-core', rev = '1.2'),
-              jar(org = 'com.twitter.common', name = 'junit-runner', rev = '0.0.41'),
+              jar(org = 'org.pantsbuild', name = 'junit-runner', rev = 'none', mutable = True,
+                  url = 'file:///home/jsirois/dev/3rdparty/jsirois-pants4/dist/junit-runner.jar'),

               # TODO(Eric Ayers) We need to rename/shade the dependencies of junit-runner
               #      or use a custom classloader for junit runner to permanently
diff --git a/src/python/pants/backend/jvm/tasks/junit_run.py b/src/python/pants/backend/jvm/tasks/junit_run.py
index 0c48798..509bf26 100644
--- a/src/python/pants/backend/jvm/tasks/junit_run.py
+++ b/src/python/pants/backend/jvm/tasks/junit_run.py
@@ -649,7 +649,7 @@ class Cobertura(_Coverage):

 class JUnitRun(JvmTask, JvmToolTaskMixin):
-  _MAIN = 'com.twitter.common.junit.runner.ConsoleRunner'
+  _MAIN = 'org.pantsbuild.tools.junit.ConsoleRunner'

   @classmethod
   def register_options(cls, register):
```

CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/57658118

Bugs cl... (continued)

13012 of 18620 relevant lines covered (69.88%)

0.7 hits per line

Jobs
ID Job ID Ran Files Coverage
1 4387.1 (CI_FLAGS="-cjlpnet 'Various pants self checks'") 0
Travis Job 4387.1
2 4387.2 (CI_FLAGS="-fkmsrcjlpn 'Test examples and testprojects'") 0
Travis Job 4387.2
3 4387.3 (CI_FLAGS="-fkmsrcnet 'Unit tests for pants and pants-plugins'") 0
69.88
 Travis Job 4387.3
4 4387.4 (CI_FLAGS="-fkmsrcjlpet 'Python contrib tests'") 0
Travis Job 4387.4
5 4387.5 (CI_FLAGS="-fkmsrjlpnet -i 6:0 'Python integration tests for pants - shard 1'") 0
Travis Job 4387.5
6 4387.6 (CI_FLAGS="-fkmsrjlpnet -i 6:1 'Python integration tests for pants - shard 2'") 0
Travis Job 4387.6
7 4387.7 (CI_FLAGS="-fkmsrjlpnet -i 6:2 'Python integration tests for pants - shard 3'") 0
Travis Job 4387.7
8 4387.8 (CI_FLAGS="-fkmsrjlpnet -i 6:3 'Python integration tests for pants - shard 4'") 0
Travis Job 4387.8
9 4387.9 (CI_FLAGS="-fkmsrjlpnet -i 6:4 'Python integration tests for pants - shard 5'") 0
Travis Job 4387.9
10 4387.10 (CI_FLAGS="-fkmsrjlpnet -i 6:5 'Python integration tests for pants - shard 6'") 0
Travis Job 4387.10
Source Files on build 4387
Detailed source file information is not available for this build.