developit / preact / 3337

100%

push

travis-ci

Fix remove button adding todos in demo app (#1488)

This PR fixes an issue where the `x` buttons in the todo demo would actually add a todo instead of removing it. Note that there is a second issue at play that needs to fixed separately which causes stale dom nodes when wrapped in a `Fragment`.

The issue is caused by weird browser behavior which treat any `<buttton>` that doesn't have a `type` attribute as a `submit` button if it is inside a `<form>` :man_shrugging:

In our case it would immediately submit the form which always adds a todo.
```jsx
<form onSubmit={this.addTodo} action="javascript:">...</form>
```

707 of 1106 branches covered (63.92%)

774 of 774 relevant lines covered (100.0%)

414.99 hits per line