developit / preact

98%

master: 100%

LAST BUILD ON BRANCH fix/inproper_unmount

branch: SELECT

CHANGE BRANCH

x

• No branch selected
• 10.0.0-alpha.0
• 10.0.0-alpha.1
• 10.0.0-alpha.2
• 10.0.0-alpha.3
• 10.0.0-alpha.4
• 10.0.0-beta.0
• 10.0.0-beta.1
• 7.1.0
• 7.2.0
• 7.2.1
• 7.x
• 8
• 8.0.0
• 8.0.1
• 8.1.0
• 8.2.0
• 8.2.1
• 8.2.2
• 8.2.3
• 8.2.4
• 8.2.5
• 8.2.6
• 8.2.7
• 8.2.8
• 8.2.9
• 8.3.0
• 8.3.1
• 8.4.0
• 8.4.1
• 8.4.2
• NekR-patch-1
• alpha1
• anim_delay
• attribute-free-hydration
• before_input
• bug/fix-self-ref-for-non-browser
• bug/ie
• bugfix/prevstate-batching
• ceviche
• chore/abstractLoop
• chore/bundleSize
• chore/cleanup-pkg
• chore/debugRender
• chore/dx
• chore/dx-useCb-useMemo
• chore/lowHangingFruit
• chore/supportJsxSourceBabelPlugin
• chore/warnMissingDep
• chore/warnOnce
• clear-props-on-recycle
• clear_logger
• code_coverage
• compat_clone
• compat_create-factory
• createref-support
• cross_browser
• debug-component-thrashing
• debug-component-thrashing-1
• deterministic-test-serialization
• devtools-handle-unmount
• devtools-prevstate
• devtools-tweaks
• devtools/portals
• devtools_hooks
• dist_tests
• dom_willunmount
• dont-leak-text-vnodes
• editorconfig-tweak
• event-case
• feat/debugHtmlMarkup
• feat/preventJSONInjection
• feat/putt-putt-styles
• feat/shortCircuitDiff
• feat/useImperativeHandle
• feat/utils
• feat/warnDeprecatedProps
• feat/warnUsingHooksOutsideRender
• feature/parking-suspense
• feature/update-deps
• fix-924
• fix-compat-server
• fix-debug-createref
• fix-force-flag
• fix-mangle-config
• fix-ref-invocation
• fix-top-level-unmount
• fix/add-support-for-global-event-handlers
• fix/debug
• fix/effect_execution_order
• fix/emptyDomComparison
• fix/emptyDomComparison-2
• fix/errorBoundary
• fix/event
• fix/hooksDiff
• fix/hot-loader
• fix/inproper_unmount
• fix/issuesFromGolfing
• fix/nullishLastDomChild
• fix/patchEventPersist
• fix/portalsInsertion
• fix/replaceNodeWithComponents
• fix/typesOptions
• fix/useState
• fix_async_router
• fix_component_hoisting
• fix_img_width
• fix_invalid_dom
• fix_portals
• fix_some_types
• fix_stale_fragment
• fix_static_typing
• forward_fix_tests
• fragment_reordering2
• gh-1586
• golf/diff
• greenkeeper-copyfiles-1.1.0
• greenkeeper-copyfiles-1.1.1
• greenkeeper-copyfiles-1.2.0
• greenkeeper-coveralls-2.11.16
• greenkeeper-coveralls-2.13.0
• greenkeeper-coveralls-2.13.1
• greenkeeper-cross-env-3.1.4
• greenkeeper-cross-env-3.2.4
• greenkeeper-cross-env-4.0.0
• greenkeeper-diff-3.2.0
• greenkeeper-eslint-3.12.0
• greenkeeper-eslint-3.12.1
• greenkeeper-eslint-3.13.0
• greenkeeper-eslint-3.13.1
• greenkeeper-eslint-3.14.0
• greenkeeper-eslint-3.14.1
• greenkeeper-eslint-3.15.0
• greenkeeper-eslint-3.16.0
• greenkeeper-eslint-3.16.1
• greenkeeper-eslint-3.17.0
• greenkeeper-eslint-3.18.0
• greenkeeper-eslint-3.19.0
• greenkeeper-eslint-3.8.0
• greenkeeper-eslint-3.8.1
• greenkeeper-eslint-plugin-react-6.10.0
• greenkeeper-eslint-plugin-react-6.10.1
• greenkeeper-eslint-plugin-react-6.10.2
• greenkeeper-eslint-plugin-react-6.10.3
• greenkeeper-eslint-plugin-react-6.8.0
• greenkeeper-eslint-plugin-react-6.9.0
• greenkeeper-eslint-plugin-react-7.0.0
• greenkeeper-gzip-size-cli-2.0.0
• greenkeeper-karma-1.4.0
• greenkeeper-karma-1.4.1
• greenkeeper-karma-1.5.0
• greenkeeper-karma-1.6.0
• greenkeeper-karma-1.7.0
• greenkeeper-karma-chrome-launcher-2.1.0
• greenkeeper-karma-chrome-launcher-2.1.1
• greenkeeper-karma-mocha-reporter-2.2.2
• greenkeeper-karma-mocha-reporter-2.2.3
• greenkeeper-karma-phantomjs-launcher-1.0.3
• greenkeeper-karma-phantomjs-launcher-1.0.4
• greenkeeper-karma-webpack-1.8.1
• greenkeeper-karma-webpack-2.0.1
• greenkeeper-karma-webpack-2.0.2
• greenkeeper-karma-webpack-2.0.3
• greenkeeper-mocha-3.3.0
• greenkeeper-npm-run-all-3.1.1
• greenkeeper-npm-run-all-3.1.2
• greenkeeper-npm-run-all-4.0.0
• greenkeeper-npm-run-all-4.0.1
• greenkeeper-npm-run-all-4.0.2
• greenkeeper-phantomjs-prebuilt-2.1.14
• greenkeeper-rimraf-2.6.0
• greenkeeper-rimraf-2.6.1
• greenkeeper-rollup-0.34.5
• greenkeeper-rollup-0.36.2
• greenkeeper-rollup-0.36.3
• greenkeeper-rollup-0.36.4
• greenkeeper-rollup-0.37.0
• greenkeeper-rollup-0.37.1
• greenkeeper-rollup-0.37.2
• greenkeeper-rollup-0.38.0
• greenkeeper-rollup-0.38.1
• greenkeeper-rollup-0.38.2
• greenkeeper-rollup-0.38.3
• greenkeeper-rollup-0.39.0
• greenkeeper-rollup-0.39.1
• greenkeeper-rollup-0.39.2
• greenkeeper-rollup-0.40.0
• greenkeeper-rollup-0.40.1
• greenkeeper-rollup-0.40.2
• greenkeeper-rollup-0.41.0
• greenkeeper-rollup-0.41.1
• greenkeeper-rollup-0.41.2
• greenkeeper-rollup-0.41.3
• greenkeeper-rollup-0.41.4
• greenkeeper-rollup-0.41.5
• greenkeeper-rollup-0.41.6
• greenkeeper-rollup-plugin-node-resolve-2.1.0
• greenkeeper-rollup-plugin-node-resolve-2.1.1
• greenkeeper-rollup-plugin-node-resolve-3.0.0
• greenkeeper-sinon-1.17.7
• greenkeeper-sinon-2.2.0
• greenkeeper-sinon-chai-2.10.0
• greenkeeper-sinon-chai-2.9.0
• greenkeeper-typescript-2.3.1
• greenkeeper-typescript-2.3.2
• greenkeeper-uglify-js-2.7.5
• greenkeeper-uglify-js-2.8.0
• greenkeeper-uglify-js-2.8.1
• greenkeeper-uglify-js-2.8.10
• greenkeeper-uglify-js-2.8.11
• greenkeeper-uglify-js-2.8.12
• greenkeeper-uglify-js-2.8.13
• greenkeeper-uglify-js-2.8.14
• greenkeeper-uglify-js-2.8.15
• greenkeeper-uglify-js-2.8.17
• greenkeeper-uglify-js-2.8.18
• greenkeeper-uglify-js-2.8.19
• greenkeeper-uglify-js-2.8.20
• greenkeeper-uglify-js-2.8.21
• greenkeeper-uglify-js-2.8.22
• greenkeeper-uglify-js-2.8.23
• greenkeeper-uglify-js-2.8.4
• greenkeeper-uglify-js-2.8.5
• greenkeeper-webpack-1.14.0
• greenkeeper-webpack-2.5.0
• greenkeeper-webpack-2.5.1
• holes2
• hotfix/8.3.1
• html_for
• hydrate-dangerouslysetinnerhtml
• hydrate_class
• ie11_remove
• ie11_win7
• improve-act
• improve-fragments-2-rebase
• improve-fragments-3
• improve-fragments-childDom
• improve-fragments-childDom-golf
• inline-vnode-children
• k1r0s-patch-1
• karma_wrong_require
• keep-options-debouncerendering
• keys_reuse
• kristoferbaxter-patch-1
• mangle-props-fix
• master
• min_max
• mobx-react
• module-export-mjs
• multi_select
• multiple_contexts
• new_devtools
• numeric_css
• object_assign
• old_css_string
• optimize-cloneelement
• options-rename
• people-browser-demo
• pfc-constructor
• pfc-rewrite
• placeChildren
• portals_proto
• props_reuse
• puppeteer-chromium-install
• pure-super
• putt-putt
• ref-clearing-perf
• refactor/golfHooks
• release_10-0-0-beta-1
• release_10.0.0-alpha.3
• release_10.0.0-alpha.4
• release_10.0.0-beta.0
• remote-testing
• remove-amdname
• remove_double_promise
• remove_unused_import
• revert-1016-master
• revert-1460-drop-extra-dep
• revert/Revert-the-documentView-lookup
• sangupta-master
• sauce-test
• saucelabs_timeouts
• scratch/perf
• setstate_this
• simpler-key-matching
• size
• size-optimizations
• skip-coercion
• stale_props_scu
• state_test
• styled_components_example
• svg_foreign_object
• switch_js
• testing/effects
• tests-fix-hydrate
• tests-scu-state
• tests/safari-11
• todo_demo
• travis_email
• travis_saucelabs
• ts-add-missing-element
• ts-fixes
• ts_types_react
• uglifyjs-3
• unmount_portals
• use-debug-value
• validate_tag
• vnode-prop-explorations
• x-react-devtools-hook

Build # 4202

Build Type

Pull #1639

travis-ci

Committed by web-flow

Commit Message

apply pr remark, change the check one line earlier so skipRemove can only be set on dom/text nodes.

Pull Request Pull Request #1639: (fix) - incorrect unmount

Run Details

791 of 861 branches covered (91.87%)

1 of 1 new or added line in 1 file covered. (100.0%)

872 of 887 relevant lines covered (98.31%)

500.07 hits per line