pantsbuild / pants / 4219
0%
main: 93%

LAST BUILD BRANCH: 2.33.x
DEFAULT BRANCH: main
Ran
Jobs 10
Files 319
Run time 14min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
4219

push

travis-ci

jsirois 
Fixup minified_dependencies.

This change fixes the core of the SetupPy minified_dependencies and adds
a hack dependency to each of pants 3 auxiliary sdist targets to produce
correct sdists with no repeated code and an exact set of setup_requires.

The SetupPy test is moved to its proper parallel test tree home and a
test for the pantsbuild.pants contrib sdist case is added that fails
before the fix.

A follow-on change will remove the need for the 3 hack deps by imposing
a well defined global ownership model for python targets that don't
provide - tracked here: https://github.com/pantsbuild/pants/issues/1329

Testing Done:
Manual testing included 1st verifying the auxialiary sdists now only
contained the source files they owned and not the transitive set of
pants files they used:
```console
$ ./build-support/bin/release.sh -n
$ for tar in dist/*.tar.gz; do tar -xzf $tar -C dist/; done
$ cat dist/pantsbuild.pants.contrib.scrooge-0.0.31/src/pantsbuild.pants.contrib.scrooge.egg-info/namespace_packages.txt
pants
pants.contrib
$ cat dist/pantsbuild.pants.contrib.scrooge-0.0.31/src/pantsbuild.pants.contrib.scrooge.egg-info/requires.txt
pantsbuild.pants==0.0.31
twitter.common.collections>=0.3.1,<0.4
$ cat dist/pantsbuild.pants.contrib.scrooge-0.0.31/src/pantsbuild.pants.contrib.scrooge.egg-info/SOURCES.txt
MANIFEST.in
setup.py
src/pants/__init__.py
src/pants/contrib/__init__.py
src/pants/contrib/scrooge/__init__.py
src/pants/contrib/scrooge/register.py
src/pants/contrib/scrooge/tasks/__init__.py
src/pants/contrib/scrooge/tasks/scrooge_gen.py
src/pants/contrib/scrooge/tasks/thrift_linter.py
src/pantsbuild.pants.contrib.scrooge.egg-info/PKG-INFO
src/pantsbuild.pants.contrib.scrooge.egg-info/SOURCES.txt
src/pantsbuild.pants.contrib.scrooge.egg-info/dependency_links.txt
src/pantsbuild.pants.contrib.scrooge.egg-info/namespace_packages.txt
src/pantsbuild.pants.contrib.scrooge.egg-info/requires.txt
src/pantsbuild.pants.contrib.scrooge.egg-info/top_level.txt
src/pantsbuild.pants.contrib.scrooge.egg-info/zip-safe
```
Same went for pantsbuild.pants.testinfra.

I also did the twitter/commons sdists release prep with the
`./build-support/commons/scripts/build_py_commons.sh` script before
and after and found all sdist diffs were 3rdparty dep additions like
so:
```console
$ diff -rx *.tar.gz old/ new/
diff -rx '*.tar.gz' old/twitter.common.app-0.3.3/setup.py new/twitter.common.app-0.3.3/setup.py
13a14
>                             'twitter.common.lang==0.3.3',
14a16
>                             'twitter.common.options==0.3.3',
diff -rx '*.tar.gz' old/twitter.common.app-0.3.3/src/twitter.common.app.egg-info/requires.txt new/twitter.common.app-0.3.3/src/twitter.common.app.egg-info/requires.txt
1a2
> twitter.common.lang==0.3.3
2a4
> twitter.common.options==0.3.3
diff -rx '*.tar.gz' old/twitter.common.concurrent-0.3.3/setup.py new/twitter.common.concurrent-0.3.3/setup.py
14a15
>                             'twitter.common.lang==0.3.3',
diff -rx '*.tar.gz' old/twitter.common.concurrent-0.3.3/src/twitter.common.concurrent.egg-info/requires.txt new/twitter.common.concurrent-0.3.3/src/twitter.common.concurrent.egg-info/requires.txt
2a3
> twitter.common.lang==0.3.3
...
```
This makes sense because one change to the dep minification algorithm
was to acheive an exact set of setup_requires and not the old minified
set.  Its only the local source files retained in the sdist that are
minified.

CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/55903062

Bugs closed: 1126, 1326

Reviewed at https://rbcommons.com/s/twitter/r/1986/

12758 of 18445 relevant lines covered (69.17%)

0.69 hits per line

Jobs
ID Job ID Ran Files Coverage
1 4219.1 (CI_FLAGS="-clpnet 'Various pants self checks'") 0
Travis Job 4219.1
2 4219.2 (CI_FLAGS="-fkmsrclpn 'Test examples and testprojects'") 0
Travis Job 4219.2
3 4219.3 (CI_FLAGS="-fkmsrcnet 'Python unit tests for pants and pants-plugins'") 0
69.17
 Travis Job 4219.3
4 4219.4 (CI_FLAGS="-fkmsrclpet 'Python contrib tests'") 0
Travis Job 4219.4
5 4219.5 (CI_FLAGS="-fkmsrlpnet -i 6:0 'Python integration tests for pants - shard 1'") 0
Travis Job 4219.5
6 4219.6 (CI_FLAGS="-fkmsrlpnet -i 6:1 'Python integration tests for pants - shard 2'") 0
Travis Job 4219.6
7 4219.7 (CI_FLAGS="-fkmsrlpnet -i 6:2 'Python integration tests for pants - shard 3'") 0
Travis Job 4219.7
8 4219.8 (CI_FLAGS="-fkmsrlpnet -i 6:3 'Python integration tests for pants - shard 4'") 0
Travis Job 4219.8
9 4219.9 (CI_FLAGS="-fkmsrlpnet -i 6:4 'Python integration tests for pants - shard 5'") 0
Travis Job 4219.9
10 4219.10 (CI_FLAGS="-fkmsrlpnet -i 6:5 'Python integration tests for pants - shard 6'") 0
Travis Job 4219.10
Source Files on build 4219
Detailed source file information is not available for this build.