spulec / moto / 4318

93%

master: 95%

Pull #2077

travis-ci

Check record type when upserting.

Previously this was not checked so an existing record (e.g. with type A) would be overwritten on upsert by a record with the same name but different type (e.g. TXT).

This commit also:

* publicizes the type variable appending the underscore affix (required to maintain compatibility with CloudFormation which sets type as the CF type),
* fixes a wrong assumption in tests that UPSERT applies a change to Type (it creates a distinct record instead),
* Updates ACM model to use serial_number instead of deprecated and remove serial causing Travis failures.

3 of 3 new or added lines in 1 file covered. (100.0%)

27054 of 29118 relevant lines covered (92.91%)

4.64 hits per line