4318

pending completion

Build # 4318

Build Type

Pull #2077

travis-ci

Committed by

web-flow

Commit Message

Check record type when upserting.

Previously this was not checked so an existing record (e.g. with type A) would be overwritten on upsert by a record with the same name but different type (e.g. TXT).

This commit also:

* publicizes the type variable appending the underscore affix (required to maintain compatibility with CloudFormation which sets type as the CF type),
* fixes a wrong assumption in tests that UPSERT applies a change to Type (it creates a distinct record instead),
* Updates ACM model to use serial_number instead of deprecated and remove serial causing Travis failures.

Pull Request Pull Request #2077: Check record type when upserting.

Run Details

3 of 3 new or added lines in 1 file covered. (100.0%)

27054 of 29118 relevant lines covered (92.91%)

4.64 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

90.16

/moto/logs/models.py

Build SHA Not Found

The commit SHA "5dc953585c093f1c53ca989fefba65bd365b385f" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

spulec / moto / 4318

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous