4208
0%
main: 93%

Ran 25 Mar 2015 05:00PM UTC

Jobs 10

Files 319

Run time 15min

Badge

Embed ▾

pending completion

Build # 4208

Build Type

push

travis-ci

Committed by

stuhood

Commit Message

Ignore blank lines and comments in scalastyle excludes file

Problem:
The scalastyle plugin does not skip blank lines when parsing the excludes file. Blank lines turn into empty regex patterns which then match all files. This probably not what the user had in mind.

Solution:
Skip lines consisting only of whitespace or starting with '#' when processing hte excludes file

Result:
Users of the plugin can safely include blank lines and comments in their excludes file.

Testing Done:
./pants test tests/python/pants_test/backend/jvm/tasks:scalastyle

Reviewed at https://rbcommons.com/s/twitter/r/1971/

Coverage Stats

12756 of 18444 relevant lines covered (69.16%)

0.69 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	4208.1 (CI_FLAGS="-clpnet 'Various pants self checks'")	25 Mar 2015 05:05PM UTC		Travis Job 4208.1
2	4208.2 (CI_FLAGS="-fkmsrclpn 'Test examples and testprojects'")	25 Mar 2015 05:00PM UTC		Travis Job 4208.2
3	4208.3 (CI_FLAGS="-fkmsrcnet 'Python unit tests for pants and pants-plugins'")	25 Mar 2015 05:02PM UTC	69.16	Travis Job 4208.3
4	4208.4 (CI_FLAGS="-fkmsrclpet 'Python contrib tests'")	25 Mar 2015 05:02PM UTC		Travis Job 4208.4
5	4208.5 (CI_FLAGS="-fkmsrlpnet -i 6:0 'Python integration tests for pants - shard 1'")	25 Mar 2015 05:00PM UTC		Travis Job 4208.5
6	4208.6 (CI_FLAGS="-fkmsrlpnet -i 6:1 'Python integration tests for pants - shard 2'")	25 Mar 2015 05:09PM UTC		Travis Job 4208.6
7	4208.7 (CI_FLAGS="-fkmsrlpnet -i 6:2 'Python integration tests for pants - shard 3'")	25 Mar 2015 05:09PM UTC		Travis Job 4208.7
8	4208.8 (CI_FLAGS="-fkmsrlpnet -i 6:3 'Python integration tests for pants - shard 4'")	25 Mar 2015 05:08PM UTC		Travis Job 4208.8
9	4208.9 (CI_FLAGS="-fkmsrlpnet -i 6:4 'Python integration tests for pants - shard 5'")	25 Mar 2015 05:10PM UTC		Travis Job 4208.9
10	4208.10 (CI_FLAGS="-fkmsrlpnet -i 6:5 'Python integration tests for pants - shard 6'")	25 Mar 2015 05:14PM UTC		Travis Job 4208.10

Source Files on build 4208

Detailed source file information is not available for this build.

pantsbuild / pants / 4208
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4208

pantsbuild / pants / 4208 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4208

pantsbuild / pants / 4208
0%
main: 93%

README BADGES
x