4190
0%
main: 93%

Ran 24 Mar 2015 01:20AM UTC

Jobs 10

Files 319

Run time 19min

Badge

Embed ▾

pending completion

Build # 4190

Build Type

push

travis-ci

Committed by

stuhood

Commit Message

Add the JvmCompileIsolatedStrategy

Adds an isolated compile strategy, which sequentially compiles targets from a chunk and passes upstream classpaths to downstream compilation. This hasn't had large scale testing internally yet, but it already compiles and caches medium-sized java and scala targets successfully.

- Edits to the ABC to support isolation
- Implement JvmCompileIsolatedStrategy
- Select the compile strategy with a JvmCompile flag. Side-effect: you can run any of apt/java/scala with any combination of isolated/global
- Incorporate the strategy into the platform_version_info, to give artifacts for each strategy different cache keys
- Add a decorator to support parameterizing the strategy into unit tests

There are a few known issues with this strategy that affect this review:
*Nice-to-haves*
1. Should gain back support for "--unnecessary-deps" and "--missing-direct-deps" (doesn't need "--missing-deps")
2. It's (probably?) very slow
3. Options for both strategies are registered, regardless of which strategy is selected (could be fixed with [subsystems](https://docs.google.com/document/d/1hinJLcTDyx1Rz8FvWU-I1m0WQzt3ynxSdbRHLmhBAek/edit?usp=sharing)?)

Testing Done:
https://github.com/pantsbuild/pants/pull/1235

Reviewed at https://rbcommons.com/s/twitter/r/1898/

Coverage Stats

12760 of 18449 relevant lines covered (69.16%)

0.69 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	4190.1 (CI_FLAGS="-clpnet 'Various pants self checks'")	24 Mar 2015 01:21AM UTC		Travis Job 4190.1
2	4190.2 (CI_FLAGS="-fkmsrclpn 'Test examples and testprojects'")	24 Mar 2015 01:20AM UTC		Travis Job 4190.2
3	4190.3 (CI_FLAGS="-fkmsrcnet 'Python unit tests for pants and pants-plugins'")	24 Mar 2015 01:25AM UTC	69.16	Travis Job 4190.3
4	4190.4 (CI_FLAGS="-fkmsrclpet 'Python contrib tests'")	24 Mar 2015 01:24AM UTC		Travis Job 4190.4
5	4190.5 (CI_FLAGS="-fkmsrlpnet -i 6:0 'Python integration tests for pants - shard 1'")	24 Mar 2015 01:25AM UTC		Travis Job 4190.5
6	4190.6 (CI_FLAGS="-fkmsrlpnet -i 6:1 'Python integration tests for pants - shard 2'")	24 Mar 2015 01:31AM UTC		Travis Job 4190.6
7	4190.7 (CI_FLAGS="-fkmsrlpnet -i 6:2 'Python integration tests for pants - shard 3'")	24 Mar 2015 01:30AM UTC		Travis Job 4190.7
8	4190.8 (CI_FLAGS="-fkmsrlpnet -i 6:3 'Python integration tests for pants - shard 4'")	24 Mar 2015 01:30AM UTC		Travis Job 4190.8
9	4190.9 (CI_FLAGS="-fkmsrlpnet -i 6:4 'Python integration tests for pants - shard 5'")	24 Mar 2015 01:32AM UTC		Travis Job 4190.9
10	4190.10 (CI_FLAGS="-fkmsrlpnet -i 6:5 'Python integration tests for pants - shard 6'")	24 Mar 2015 01:34AM UTC		Travis Job 4190.10

Source Files on build 4190

Detailed source file information is not available for this build.

pantsbuild / pants / 4190
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4190

pantsbuild / pants / 4190 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4190

pantsbuild / pants / 4190
0%
main: 93%

README BADGES
x