4165
0%
main: 93%

Ran 21 Mar 2015 04:26AM UTC

Jobs 10

Files 319

Run time 10min

Badge

Embed ▾

pending completion

Build # 4165

Build Type

push

travis-ci

Committed by

ity

Commit Message

Removing dead code.

Note first, in passing, that `isinstance(type(action), type)` is a tautology. But, that aside, what this code seems to be trying to do is check whether the `action` is either a class representing a subclass of Task  or a function of either zero or one arguments. In the latter case it wants to make a new subclass of Task that invokes the function when executed. However, the function wrapping code can't possibly work unless I'm deeply missing something: In the `__init__` method of `FuncTask` the args parameter containing the positional arguments to `__init__` has to be either empty or contain one argument. However TaskBase in task.py defines an `__init__` that takes two positional arguments.

So any attempt to construct an instance of `FuncTask` would fail: if passed zero or one arguments, the call to `super(FuncTask, self).__init__(...)` will fail because the super constructer needs two positional arguments and if called with more than one arguments it will raise an `AssertionError` itself.

It's possible that the code was meant to refer to the args in the enclosing scope but, unless I'm very confused about Python, it does not so this code must never be used so might as well be deleted.

Testing Done:
Travis-CI.

Bugs closed: 1295

Reviewed at https://rbcommons.com/s/twitter/r/1960/

Coverage Stats

12727 of 18367 relevant lines covered (69.29%)

0.69 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	4165.1 (CI_FLAGS="-clpnet 'Various pants self checks'")	21 Mar 2015 04:28AM UTC		Travis Job 4165.1
2	4165.2 (CI_FLAGS="-fkmsrclpn 'Test examples and testprojects'")	21 Mar 2015 04:26AM UTC		Travis Job 4165.2
3	4165.3 (CI_FLAGS="-fkmsrcnet 'Python unit tests for pants and pants-plugins'")	21 Mar 2015 04:28AM UTC	69.29	Travis Job 4165.3
4	4165.4 (CI_FLAGS="-fkmsrclpet 'Python contrib tests'")	21 Mar 2015 04:26AM UTC		Travis Job 4165.4
5	4165.5 (CI_FLAGS="-fkmsrlpnet -i 6:0 'Python integration tests for pants - shard 1'")	21 Mar 2015 04:26AM UTC		Travis Job 4165.5
6	4165.6 (CI_FLAGS="-fkmsrlpnet -i 6:1 'Python integration tests for pants - shard 2'")	21 Mar 2015 04:33AM UTC		Travis Job 4165.6
7	4165.7 (CI_FLAGS="-fkmsrlpnet -i 6:2 'Python integration tests for pants - shard 3'")	21 Mar 2015 04:33AM UTC		Travis Job 4165.7
8	4165.8 (CI_FLAGS="-fkmsrlpnet -i 6:3 'Python integration tests for pants - shard 4'")	21 Mar 2015 04:32AM UTC		Travis Job 4165.8
9	4165.9 (CI_FLAGS="-fkmsrlpnet -i 6:4 'Python integration tests for pants - shard 5'")	21 Mar 2015 04:36AM UTC		Travis Job 4165.9
10	4165.10 (CI_FLAGS="-fkmsrlpnet -i 6:5 'Python integration tests for pants - shard 6'")	21 Mar 2015 04:35AM UTC		Travis Job 4165.10

Source Files on build 4165

Detailed source file information is not available for this build.

pantsbuild / pants / 4165
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4165

pantsbuild / pants / 4165 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4165

pantsbuild / pants / 4165
0%
main: 93%

README BADGES
x