12943
89%

Ran 12 Feb 2019 06:29PM UTC

Jobs 1

Files 257

Run time 141min

Badge

Embed ▾

pending completion

Build # 12943

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

core: introduce NameResolver.Helper and deprecate the params on newNameResolver() (#5345)

Context: [#4159 (comment)](https://github.com/grpc/grpc-java/issues/4159#issuecomment-415827641)

`Attributes` is appropriate for plumbing optional objects, especially useful for a long plumbing path where components in the middle may not care or see all objects in the container. It's not the case for the `params` on `newNewResolver()`. Both the default port and the proxy detector are guaranteed to be there and the plumbing path is very short. In this case, a first-class object is more appropriate and easier to use.

The `Helper` will also have `getSynchronizationContext()` (#2649) and a method to parse and validate service config. We we also considering merging `Listener` into the `Helper`, to make `NameResolver` match the `LoadBalancer` API.

Run Details

14088 of 16170 relevant lines covered (87.12%)

0.87 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	12943.1	12 Feb 2019 06:29PM UTC	0	87.12	Travis Job 12943.1

Source Files on build 12943

Detailed source file information is not available for this build.

grpc / grpc-java / 12943
89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 12943

grpc / grpc-java / 12943 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 12943

grpc / grpc-java / 12943
89%

README BADGES
x