2017
69%

Ran 17 Sep 2013 07:07PM UTC

Jobs 8

Files 262

Run time –

Badge

Embed ▾

pending completion

Build # 2017

Build Type

Pull #793

travis-ci

Committed by

flip111

Commit Message

Improved error messages in Paginator: LimitSubqueryOutputWalker



The already existing follow-up check throwing "Not all identifier properties can be found in the ResultSetMapping: %s" is a much more technical description.

If $sqlIdentifier is empty (count 0) it can be concluded that there are no mapped results. An alternative error message could thus be "The Paginator does not support queries without mapped results." (line 153).

Possibly '!=' on line 154 could be replaced by '>' because i think this is the only situation that can occur. But since i don't know this for sure, i left it like i found it.

Didn't use elseif in this commit as per Stof his suggestion.

Pull Request Pull Request #793: Improved error messages in Paginator: LimitSubqueryOutputWalker

Run Details

12699 of 14428 relevant lines covered (88.02%)

681.35 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
4	93.26	-0.99%	Doctrine/ORM/Tools/Pagination/LimitSubqueryOutputWalker.php

Jobs

ID	Job ID	Ran	Files	Coverage
1	2017.1 (DB=mysql)	17 Sep 2013 07:03PM UTC	262	87.4	Travis Job 2017.1
2	2017.2 (DB=mysql)	17 Sep 2013 07:03PM UTC	262	87.52	Travis Job 2017.2
3	2017.3 (DB=mysql)	17 Sep 2013 07:04PM UTC	262	87.57	Travis Job 2017.3
4	2017.4 (DB=pgsql)	17 Sep 2013 07:03PM UTC	261	87.7	Travis Job 2017.4
6	2017.6 (DB=pgsql)	17 Sep 2013 07:10PM UTC	261	87.87	Travis Job 2017.6
7	2017.7 (DB=sqlite)	17 Sep 2013 07:11PM UTC	261	86.73	Travis Job 2017.7
8	2017.8 (DB=sqlite)	17 Sep 2013 07:11PM UTC	261	86.86	Travis Job 2017.8
9	2017.9 (DB=sqlite)	17 Sep 2013 07:11PM UTC	261	86.91	Travis Job 2017.9

Source Files on build 2017

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

doctrine / doctrine2 / 2017
69%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 2017

doctrine / doctrine2 / 2017 69%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 2017

doctrine / doctrine2 / 2017
69%

README BADGES
x