2017

pending completion

Build # 2017

Build Type

Pull #793

travis-ci

Committed by

flip111

Commit Message

Improved error messages in Paginator: LimitSubqueryOutputWalker



The already existing follow-up check throwing "Not all identifier properties can be found in the ResultSetMapping: %s" is a much more technical description.

If $sqlIdentifier is empty (count 0) it can be concluded that there are no mapped results. An alternative error message could thus be "The Paginator does not support queries without mapped results." (line 153).

Possibly '!=' on line 154 could be replaced by '>' because i think this is the only situation that can occur. But since i don't know this for sure, i left it like i found it.

Didn't use elseif in this commit as per Stof his suggestion.

Pull Request Pull Request #793: Improved error messages in Paginator: LimitSubqueryOutputWalker

Run Details

12699 of 14428 relevant lines covered (88.02%)

681.35 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

93.26

/Doctrine/ORM/Tools/Pagination/LimitSubqueryOutputWalker.php

Build SHA Not Found

The commit SHA "f16e78012714c68d81aa3e0100f3b3acddbe357d" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

doctrine / doctrine2 / 2017

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous