pantsbuild / pants / 4137

0%

main: 93%

push

travis-ci

Fix a missing symbol in ScalaCompile.

This fixes up a missing directory member variable used to emit scalac
plugin info files for ScalacPlugin targets.  It also adds an integration
test covering straight scalac, mixed scalac/javac and the previously
raising scalac plugin case.

Also fixup JavaCompile/AptCompile, pushing apt-specific workdir member
variables and handling down to AptCompile as fallout of trying to
understand why https://rbcommons.com/s/twitter/r/1885/ broke
ScalaCompile but not JavaCompile/AptCompile.  Add a set of AptCompile
integration tests to prove out this cleanup.

In the course of fixing and adding tests, move a misplaced JavaCompile
integration test.

Testing Done:
I first noticed the problem attempting to upgrade twitter/commons to pantsbuild.pants 0.0.30:
```console
...
23:04:35 00:00   [compile]
23:04:35 00:00     [compile]
23:04:35 00:00     [jvm]
23:04:35 00:00       [jvm-compilers]
23:04:35 00:00         [find-deleted-sources]
23:04:35 00:00         [prepare-analysis]
                     Invalidated 5 targets.
23:04:36 00:01         [partition-analysis]
                     Compiling 5 scala sources in 5 targets (partition 1 of 1).
23:04:36 00:01         [compile]
23:04:36 00:01           [zinc]
                         [info] Compile success at Mar 18, 2015 11:04:36 PM [0.163s]

               Waiting for background workers to finish.
               FAILURE

Exception caught:
  File "/home/jsirois/dev/3rdparty/jsirois-twitter-commons/build-support/pants.venv/bin/pants", line 9, in <module>
    load_entry_point('pantsbuild.pants==0.0.30', 'console_scripts', 'pants')()
  File "/home/jsirois/dev/3rdparty/jsirois-twitter-commons/build-support/pants.venv/lib/python2.7/site-packages/pants/bin/pants_exe.py", line 81, in main
    _run(exiter)
  File "/home/jsirois/dev/3rdparty/jsirois-twitter-commons/build-support/pants.venv/lib/python2.7/site-packages/pants/bin/pants_exe.py", line 74, in _run
    result = goal_runner.run()
  F... (continued)

12 of 12 new or added lines in 2 files covered. (100.0%)

12743 of 18454 relevant lines covered (69.05%)

0.69 hits per line