4128
0%
main: 93%

Ran 20 Mar 2015 01:06AM UTC

Jobs 10

Files 320

Run time 14min

Badge

Embed ▾

pending completion

Build # 4128

Build Type

push

travis-ci

Committed by Benjy

Commit Message

Refactor ZincUtils.

Much of its structure was due to it previously being used not just
for compilation but also for split/merge/rebase. But now that we do those
directly in Pants code, we can simplify and streamline ZincUtils.

- Concentrates zinc argument construction in one place. Previously
  args got added piecemeal.
- Ensures that we invalidate on changes in scalac options (including
  plugins).
- Removes a superfluous sorting of invalidation arguments (the JvmFingerprintStrategy
  sorts them anyway).
- Simplifies a test and adds a new test.
- Replaces a direct config access with an option.

Testing Done:
CI passes: https://travis-ci.org/pantsbuild/pants/builds/54951792

Manual testing of scala compiles.

Reviewed at https://rbcommons.com/s/twitter/r/1946/

Coverage Stats

12742 of 18452 relevant lines covered (69.05%)

0.69 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	4128.1 (CI_FLAGS="-clpnet 'Various pants self checks'")	20 Mar 2015 01:06AM UTC		Travis Job 4128.1
2	4128.2 (CI_FLAGS="-fkmsrclpn 'Test examples and testprojects'")	20 Mar 2015 01:07AM UTC		Travis Job 4128.2
3	4128.3 (CI_FLAGS="-fkmsrcnet 'Python unit tests for pants and pants-plugins'")	20 Mar 2015 01:08AM UTC	69.05	Travis Job 4128.3
4	4128.4 (CI_FLAGS="-fkmsrclpet 'Python contrib tests'")	20 Mar 2015 01:06AM UTC		Travis Job 4128.4
5	4128.5 (CI_FLAGS="-fkmsrlpnet -i 6:0 'Python integration tests for pants - shard 1'")	20 Mar 2015 01:12AM UTC		Travis Job 4128.5
6	4128.6 (CI_FLAGS="-fkmsrlpnet -i 6:1 'Python integration tests for pants - shard 2'")	20 Mar 2015 01:11AM UTC		Travis Job 4128.6
7	4128.7 (CI_FLAGS="-fkmsrlpnet -i 6:2 'Python integration tests for pants - shard 3'")	20 Mar 2015 01:15AM UTC		Travis Job 4128.7
8	4128.8 (CI_FLAGS="-fkmsrlpnet -i 6:3 'Python integration tests for pants - shard 4'")	20 Mar 2015 01:13AM UTC		Travis Job 4128.8
9	4128.9 (CI_FLAGS="-fkmsrlpnet -i 6:4 'Python integration tests for pants - shard 5'")	20 Mar 2015 01:14AM UTC		Travis Job 4128.9
10	4128.10 (CI_FLAGS="-fkmsrlpnet -i 6:5 'Python integration tests for pants - shard 6'")	20 Mar 2015 01:20AM UTC		Travis Job 4128.10

Source Files on build 4128

Detailed source file information is not available for this build.

pantsbuild / pants / 4128
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4128

pantsbuild / pants / 4128 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4128

pantsbuild / pants / 4128
0%
main: 93%

README BADGES
x