pantsbuild / pants / 4099

0%

push

travis-ci

Avoid reparsing analysis repeatedly

- Make compute_classes_by_source abstract
- Require that compute_classes_by_source in the global strategy receives a single classes dir and analysis file

I'll move the previous implementation of this method over to the concrete class on https://rbcommons.com/s/twitter/r/1898/, where it makes more sense.

Testing Done:
https://github.com/pantsbuild/pants/pull/1280

will begin running a performance test internally to see whether this was the only issue.

Reviewed at https://rbcommons.com/s/twitter/r/1938/

22 of 22 new or added lines in 2 files covered. (100.0%)

12786 of 18516 relevant lines covered (69.05%)

0.69 hits per line