4031
0%
main: 93%

Ran 14 Mar 2015 12:27AM UTC

Jobs 10

Files 316

Run time 12min

Badge

Embed ▾

pending completion

Build # 4031

Build Type

push

travis-ci

Committed by

baroquebobcat

Commit Message

walk synthetic targets dependencies when constructing context.target()

A recent change made it so that synthetic targets dependencies aren't traversed which caused their 3rdparty deps to be not added to the classpath in certain cases. This caused compilation errors. This patch retains the derivation checks from the previous one, but expands the synthetic targets after determining which ones are needed.

RB of the patch that changed the ordering which caused the issue: https://rbcommons.com/s/twitter/r/1863/

Testing Done:
wrote unit test, verified existing behavior. ran context tests. CI baking at https://travis-ci.org/pantsbuild/pants/builds/54317247

Bugs closed: 1255

Reviewed at https://rbcommons.com/s/twitter/r/1914/

Coverage Stats

12551 of 18272 relevant lines covered (68.69%)

0.69 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	4031.1 (CI_FLAGS="-clpnet 'Various pants self checks'")	14 Mar 2015 12:28AM UTC		Travis Job 4031.1
2	4031.2 (CI_FLAGS="-fkmsrclpn 'Test examples and testprojects'")	14 Mar 2015 12:30AM UTC		Travis Job 4031.2
3	4031.3 (CI_FLAGS="-fkmsrcnet 'Python unit tests for pants and pants-plugins'")	14 Mar 2015 12:30AM UTC	68.69	Travis Job 4031.3
4	4031.4 (CI_FLAGS="-fkmsrclpet 'Python contrib tests'")	14 Mar 2015 12:27AM UTC		Travis Job 4031.4
5	4031.5 (CI_FLAGS="-fkmsrlpnet -i 6:0 'Python integration tests for pants - shard 1'")	14 Mar 2015 12:34AM UTC		Travis Job 4031.5
6	4031.6 (CI_FLAGS="-fkmsrlpnet -i 6:1 'Python integration tests for pants - shard 2'")	14 Mar 2015 12:35AM UTC		Travis Job 4031.6
7	4031.7 (CI_FLAGS="-fkmsrlpnet -i 6:2 'Python integration tests for pants - shard 3'")	14 Mar 2015 12:35AM UTC		Travis Job 4031.7
8	4031.8 (CI_FLAGS="-fkmsrlpnet -i 6:3 'Python integration tests for pants - shard 4'")	14 Mar 2015 12:35AM UTC		Travis Job 4031.8
9	4031.9 (CI_FLAGS="-fkmsrlpnet -i 6:4 'Python integration tests for pants - shard 5'")	14 Mar 2015 12:39AM UTC		Travis Job 4031.9
10	4031.10 (CI_FLAGS="-fkmsrlpnet -i 6:5 'Python integration tests for pants - shard 6'")	14 Mar 2015 12:39AM UTC		Travis Job 4031.10

Source Files on build 4031

Detailed source file information is not available for this build.

pantsbuild / pants / 4031
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4031

pantsbuild / pants / 4031 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4031

pantsbuild / pants / 4031
0%
main: 93%

README BADGES
x