activeadmin / activeadmin / 4032
79%

DEFAULT BRANCH: master
Ran
Jobs 6
Files 145
Run time 8min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
4032

Pull #3848

travis-ci

Gabe Durazo 
Fix pagination_total index option to prevent SELECT count(*) queries

The pagination_total option is supposed to prevent expensive SELECT
count(*) queries from being performed when viewing a resource's index
page.

However, while this option was hiding the display of the total number of
pages, it did not actually prevent the query from being performed.

There were two reasons:

In `#build_pagination`, the line:

`text_node paginate collection, options`

would trigger Kaminari to call `#total_pages` on the collection, which would
trigger the query:

```
    def paginate(scope, options = {}, &block)
      options[:total_pages] ||= options[:num_pages] || scope.total_pages
```

By passing in the `:total_pages` option, we short circuit this assignment
and avoid the query.

The downside is we do so by hardcoding in an essentially random total pages
count of 100. I chose the number 100, because I wanted to ensure ellipses
would appear in Kaminari's "Page 1, 2, 3, ..., Next, Last" links, no matter
how many links are configured to be displayed. However, if the resource only
had 2 pages worth of items, then clicking the "3" would result in an empty
page. That said, without querying the resource, there's no way to know how
many pages there should be.

That fix was not sufficient. In `#page_entries_info`, the call
`collection.num_pages` also triggered a SELECT count(*). I re-arranged
the conditionals to avoid that call if `@display_total` is false, while
trying to keep the behavior the same.
Pull Request #3848:

3613 of 3832 relevant lines covered (94.28%)

549.89 hits per line

Jobs
ID Job ID Ran Files Coverage
1 4032.1 (1.9, RAILS=3.2.21) 145
94.06
 Travis Job 4032.1
2 4032.2 (1.9, RAILS=4.1.8) 145
94.22
 Travis Job 4032.2
3 4032.3 (1.9, RAILS=4.2.0) 145
94.22
 Travis Job 4032.3
4 4032.4 (2.1, RAILS=3.2.21) 145
94.06
 Travis Job 4032.4
5 4032.5 (2.2, RAILS=4.1.8) 145
Travis Job 4032.5
6 4032.6 (2.2, RAILS=4.2.0) 145
94.22
 Travis Job 4032.6
Source Files on build 4032
Coverage ∆ File Lines Relevant Covered Missed Hits/Line