openconfig / ygot / 1232

89%

push

travis-ci

Issue 185: Relative leafref that traverses list boundary in an uncompressed schema fails validation (#214)

* Fix bug where a list was considered twice in a schematree path.

* Fix issue #185.

 * (M) util/reflect.go
   - Fix an issue whereby in uncompressed schemas, relative references
     would fail if they traversed a list boundary, since the path
     traversal would always try and skip the parent surrounding
     container since it assumed compression was enabled. The fix is
     to read the annotation in the schema to determine whether we
     are dealing with a compressed schema, and only make this skip
     during cases where path compression is enabled.
 * (M) util/reflect_test.go
   - Unit tests for reading the schema annotation.
 * (M) ygen/schemaparse.go
   - Switch to using a common const for the schema compression
     annotation.
 * (M) integration_tests/uncompressed/...
   - Add a specific integration test for ygen, ytypes, and util to
     cover this case. Fake input data provides partial coverage for
     this scenario, however, since it relies on generated code plus
     these being read in util, this test integrates the three.

* Remove erroneous YANG file.

* Update Makefile for travis tests.

* Implement fix for skipping a level only in the leafref lookup code.

32 of 32 new or added lines in 3 files covered. (100.0%)

8442 of 9274 relevant lines covered (91.03%)

1809.77 hits per line