activeadmin
/
activeadmin
/
3906
59%
master: 79%
master: 79%
|
Ran
|
Jobs
7
|
Files
210
|
Run time
13min
|
Badge
Embed ▾
README BADGES
|
travis-ci
Ryan Dlugosz
Add parens to method calls used as arg defaults, fix #3733 Ruby 2.2 included a [bug fix](https://bugs.ruby-lang.org/issues/9593) that impacts methods which call other methods as defaults for some of their arguments, e.g., `def bar(foo=foo)`. The fix is to include parenthesis on the method call, `def bar(foo=foo())`. A similar patch was [recently made](https://github.com/rails/rails/commit/e88da370f) to Rails to support Ruby 2.2. I only found two instances of method calls that used the problematic syntax. Failing tests revealed these methods; the following regex did not find other instances: `def.+\((\S+)\s*=\s*\1\)`. Additionally, because test-unit is not included with Ruby 2.2 (and is required for ActiveSupport 3.2.x), it has been explicitly included in the Gemfile in the Rails 3.1|2 section. It is limited to the :test group. Tests pass. The JSLint test was not executed because I did not have a JRE set up; I don't think this test is relevant to the issue at hand. Include Ruby 2.2.0 in Travis config Switch Travis "allow failures" to "exclude" for all Ruby 2.x + Rails 3.0. It is a [known issue](https://github.com/rails/rails/issues/9619) with no plan to fix. Rails 3.0.x does *not* support Rubies > 1.9.3
2232 of 3666 relevant lines covered (60.88%)
17.93 hits per line
Jobs
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | 3906.1 (1.9.3, RAILS=3.0.20) | 156 |
58.48 |
Travis Job 3906.1 | |
| 2 | 3906.2 (1.9.3, RAILS=3.1.12) | 156 |
58.52 |
Travis Job 3906.2 | |
| 3 | 3906.3 (1.9.3, RAILS=3.2.14) | 156 |
57.94 |
Travis Job 3906.3 | |
| 4 | 3906.4 (2.0.0, RAILS=3.1.12) | 156 |
58.49 |
Travis Job 3906.4 | |
| 5 | 3906.5 (2.0.0, RAILS=3.2.14) | 156 |
57.91 |
Travis Job 3906.5 | |
| 6 | 3906.6 (2.2.0, RAILS=3.1.12) | 156 |
58.49 |
Travis Job 3906.6 | |
| 7 | 3906.7 (2.2.0, RAILS=3.2.14) | 156 |
57.91 |
Travis Job 3906.7 |
Source Files on build 3906
| Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line |
|---|