581
72%

Ran 09 Jul 2018 09:38AM UTC

Jobs 2

Files 18

Run time 2min

Badge

Embed ▾

pending completion

Build # 581

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Fix handling limit of certificates per ALB (#184)

* Remove getter and setters for easier testing

Signed-off-by: Mikkel Oscar Lyderik Larsen <m@moscar.net>

* Fix handling limit of certificates per ALB

This fixes a couple of bugs related to exceeding the maximum number of
certificates per ALB.

It limits the max size to 24 instead of 25. This is done because we need
to duplicate the default certificate to work around a CloudFormation bug
(#162) and therefore need one extra space for this limiting the maximum
unique certificates per ALB to 24 instead of the AWS limit of 25.

It also fixes a bug in `AddIngress` which could potentially add some of
the certificates for a single ingress to a stack and the rest to
another stack resulting in an undesired state.

Thirdly it adds rollback complete states to `IsComplete()` to
automatically attempt to update stacks that are in a rollback complete
state.

Fix #176, #175

Signed-off-by: Mikkel Oscar Lyderik Larsen <m@moscar.net>

* Vendor with dep

Signed-off-by: Mikkel Oscar Lyderik Larsen <m@moscar.net>

* Check for nil stack

Signed-off-by: Mikkel Oscar Lyderik Larsen <m@moscar.net>

* Sync load balancer state with stack state

Signed-off-by: Mikkel Oscar Lyderik Larsen <m@moscar.net>

Run Details

964 of 2109 relevant lines covered (45.71%)

6.43 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	581.1	09 Jul 2018 09:38AM UTC	0	45.71	Travis Job 581.1
2	581.2	09 Jul 2018 09:40AM UTC	0	45.71	Travis Job 581.2

Source Files on build 581

Detailed source file information is not available for this build.

zalando-incubator / kube-ingress-aws-controller / 581
72%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 581

zalando-incubator / kube-ingress-aws-controller / 581 72%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 581

zalando-incubator / kube-ingress-aws-controller / 581
72%

README BADGES
x