11893
80%
master: 87%

Ran 23 Apr 2018 09:29AM UTC

Jobs 1

Files 347

Run time 17s

Badge

Embed ▾

pending completion

Build # 11893

Build Type

push

travis-ci

Committed by

TheAviat0r

Commit Message

sql: remove unnecessary MakeRecord opcodes

OP_MakeRecord in INSERT/UPDATE query is required for making
insertion into Tarantool and for checking constraints with
ON CONFLICT clause. There was one OP_MakeRecord for each
constraint with ON CONFLICT, and each constraint was checked by
VDBE. But now some constraints with error actions like ABORT can
be handled by Tarantool facilities (without emitting bytecode) and
therefore MakeRecord for that index would be unnecessary if it is
not a primary key index (in that case MakeRecord is also needed
for OP_IdxInsert). This patch contains a fix, which removes
unnecessary MakeRecord opcodes from INSERT/UPDATE VDBE listings.

Closes #3317

Run Details

3 of 3 new or added lines in 1 file covered. (100.0%)

60373 of 75230 relevant lines covered (80.25%)

1500290.91 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	94.15	0.09%	src/box/replication.cc
1	85.71	-14.29%	src/box/xstream.h
1	91.57	-0.74%	src/box/request.c
1	79.15	-0.15%	src/box/sql/vdbemem.c
1	75.24	26.67%	src/backtrace.cc
1	62.33	10.96%	src/util.c
2	58.62	-0.63%	src/coio.cc
2	93.96	-0.4%	src/box/vy_read_iterator.c
3	92.74	1.08%	src/box/sql/tokenize.c
3	96.4	-2.7%	src/lib/small/test/rb_rand.cc
4	86.59	-0.3%	src/box/vy_run.c
5	87.18	0.0%	src/box/iproto_constants.h
6	91.63	-1.36%	src/box/vy_cache.c
6	84.43	-3.59%	src/coio_task.c
8	42.86	-57.14%	src/box/info.h
8	96.86	0.11%	src/box/sql/update.c
9	80.85	-19.15%	src/box/vy_quota.h
10	68.24	0.0%	src/box/sql/prepare.c
11	96.3	0.0%	src/box/sql/resolve.c
11	81.25	0.22%	src/box/xrow.h
12	95.28	-0.02%	src/box/lua/tuple.c
16	89.7	0.0%	src/box/tuple.h
19	91.84	1.08%	src/box/tuple_format.c
19	94.89	-0.16%	src/box/sql/fkey.c
22	79.49	-1.31%	src/box/sql/callback.c
32	0.0	0.0%	src/box/sql/treeview.c
32	78.52	0.0%	src/box/sql/delete.c
34	92.16	0.0%	src/box/sql/parse.y
34	93.19	-0.03%	src/box/sql/analyze.c
35	92.74	0.0%	src/box/iproto.cc
36	87.47	0.25%	src/box/applier.cc
44	53.47	-0.27%	src/box/sql/alter.c
47	86.45	-0.01%	src/box/sql/vdbe.c
54	86.69	-0.02%	src/box/sql/func.c
56	86.4	-0.58%	src/box/sql/wherecode.c
57	86.61	0.18%	src/box/sql/whereexpr.c
58	88.77	-0.1%	src/box/xrow.c
66	96.84	0.0%	src/box/sql/select.c
67	89.66	0.24%	src/box/sql/insert.c
68	89.07	-0.09%	src/box/sql.c
91	53.05	0.56%	src/box/sql/pragma.c
92	70.23	-0.04%	src/box/sql/vdbesort.c
95	48.7	0.0%	src/box/sql/vdbeapi.c
181	86.51	0.03%	src/box/sql/where.c
226	87.47	-0.03%	src/box/sql/expr.c
266	82.87	-0.09%	src/box/sql/build.c
276	69.3	0.03%	src/box/sql/vdbeaux.c
315	69.99	-17.94%	src/box/vinyl.c

Jobs

ID	Job ID	Ran	Files	Coverage
3	11893.3 (TARGET=coverage)	23 Apr 2018 09:29AM UTC	347	80.25	Travis Job 11893.3

Source Files on build 11893

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

tarantool / tarantool / 11893
80%
master: 87%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 11893

tarantool / tarantool / 11893 80% master: 87%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 11893

tarantool / tarantool / 11893
80%
master: 87%

README BADGES
x